Skip to content

Commit a505b92

Browse files
committed
Swap norms in clip.cpp
1 parent dcc53b1 commit a505b92

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

tools/mtmd/clip-impl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@
6161
#define TN_LN_2 "%s.blk.%d.ln2.%s" // layer norm
6262
#define TN_LS_1 "%s.blk.%d.ls1.%s" // layer scale
6363
#define TN_LS_2 "%s.blk.%d.ls2.%s" // layer scale
64-
#define TN_ATTN_Q_NORM "%s.blk.%d.attn_q_norm.%s"
6564
#define TN_ATTN_K_NORM "%s.blk.%d.attn_k_norm.%s"
65+
#define TN_ATTN_Q_NORM "%s.blk.%d.attn_q_norm.%s"
6666
#define TN_LN_PRE "%s.pre_ln.%s"
6767
#define TN_LN_POST "%s.post_ln.%s"
6868
#define TN_LLAVA_PROJ "mm.%d.%s"

tools/mtmd/clip.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1372,7 +1372,7 @@ struct clip_graph {
13721372
}
13731373

13741374
if (layer.k_norm) {
1375-
Kcur = build_norm(Kcur, layer.q_norm, NULL, norm_t, eps, il);
1375+
Kcur = build_norm(Kcur, layer.k_norm, NULL, norm_t, eps, il);
13761376
cb(Kcur, "Kcur_norm", il);
13771377
}
13781378

@@ -2005,8 +2005,8 @@ struct clip_model_loader {
20052005
layer.ln_2_w = get_tensor(string_format(TN_LN_2, "v", il, "weight"), false);
20062006
layer.ls_1_w = get_tensor(string_format(TN_LS_1, "v", il, "weight"), false); // no bias
20072007
layer.ls_2_w = get_tensor(string_format(TN_LS_2, "v", il, "weight"), false); // no bias
2008-
layer.k_norm = get_tensor(string_format(TN_ATTN_Q_NORM, "v", il, "weight"), false);
2009-
layer.q_norm = get_tensor(string_format(TN_ATTN_K_NORM, "v", il, "weight"), false);
2008+
layer.k_norm = get_tensor(string_format(TN_ATTN_K_NORM, "v", il, "weight"), false);
2009+
layer.q_norm = get_tensor(string_format(TN_ATTN_Q_NORM, "v", il, "weight"), false);
20102010

20112011
layer.k_b = get_tensor(string_format(TN_ATTN_K, "v", il, "bias"), false);
20122012
layer.q_b = get_tensor(string_format(TN_ATTN_Q, "v", il, "bias"), false);

0 commit comments

Comments
 (0)