Skip to content

Commit a54efe2

Browse files
committed
llama : remove apple-a12 flag for ios-sim and ios-device builds
This commit removes the -mcpu=apple-a12 flag from the ios-sim and ios-device builds. This should not be required now that we are setting GGML_NATIVE=OFF. The motivation for this is that these flags were causing the following error when building the xcframework: ```console clang: error: unsupported option '-mcpu=' for target 'x86_64-apple-ios16.4-simulator' ```
1 parent 03d36cd commit a54efe2

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

build-xcframework.sh

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,8 @@ cmake -B build-ios-sim -G Xcode \
139139
-DCMAKE_OSX_SYSROOT=iphonesimulator \
140140
-DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" \
141141
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=iphonesimulator \
142-
-DCMAKE_C_FLAGS="-mcpu=apple-a12 ${COMMON_C_FLAGS}" \
143-
-DCMAKE_CXX_FLAGS="-mcpu=apple-a12 ${COMMON_CXX_FLAGS}" \
142+
-DCMAKE_C_FLAGS="${COMMON_C_FLAGS}" \
143+
-DCMAKE_CXX_FLAGS="${COMMON_CXX_FLAGS}" \
144144
-S .
145145
cmake --build build-ios-sim --config Release -- -quiet
146146

@@ -151,8 +151,8 @@ cmake -B build-ios-device -G Xcode \
151151
-DCMAKE_OSX_SYSROOT=iphoneos \
152152
-DCMAKE_OSX_ARCHITECTURES="arm64" \
153153
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=iphoneos \
154-
-DCMAKE_C_FLAGS="-mcpu=apple-a12 ${COMMON_C_FLAGS}" \
155-
-DCMAKE_CXX_FLAGS="-mcpu=apple-a12 ${COMMON_CXX_FLAGS}" \
154+
-DCMAKE_C_FLAGS="${COMMON_C_FLAGS}" \
155+
-DCMAKE_CXX_FLAGS="${COMMON_CXX_FLAGS}" \
156156
-S .
157157
cmake --build build-ios-device --config Release -- -quiet
158158

@@ -161,8 +161,8 @@ cmake -B build-macos -G Xcode \
161161
"${COMMON_CMAKE_ARGS[@]}" \
162162
-DCMAKE_OSX_DEPLOYMENT_TARGET=${MACOS_MIN_OS_VERSION} \
163163
-DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" \
164-
-DCMAKE_C_FLAGS="-mcpu=apple-a12 ${COMMON_C_FLAGS}" \
165-
-DCMAKE_CXX_FLAGS="-mcpu=apple-a12 ${COMMON_CXX_FLAGS}" \
164+
-DCMAKE_C_FLAGS="${COMMON_C_FLAGS}" \
165+
-DCMAKE_CXX_FLAGS="${COMMON_CXX_FLAGS}" \
166166
-S .
167167
cmake --build build-macos --config Release -- -quiet
168168

0 commit comments

Comments
 (0)