Skip to content

Commit b143fbc

Browse files
authored
ci : fix hang in windows-hip build/release (#15365)
* fix hang in windows-latest-cmake-hip * apply fix to release as well
1 parent de56279 commit b143fbc

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

.github/workflows/build.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1070,7 +1070,8 @@ jobs:
10701070
write-host "Downloading AMD HIP SDK Installer"
10711071
Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-24.Q3-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe"
10721072
write-host "Installing AMD HIP SDK"
1073-
Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -Wait
1073+
$proc = Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -PassThru
1074+
$proc.WaitForExit(600000)
10741075
write-host "Completed AMD HIP SDK installation"
10751076
10761077
- name: Verify ROCm

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -557,7 +557,8 @@ jobs:
557557
write-host "Downloading AMD HIP SDK Installer"
558558
Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-24.Q3-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe"
559559
write-host "Installing AMD HIP SDK"
560-
Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -Wait
560+
$proc = Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -PassThru
561+
$proc.WaitForExit(600000)
561562
write-host "Completed AMD HIP SDK installation"
562563
563564
- name: Verify ROCm

0 commit comments

Comments
 (0)