ggml-metal : fix padding in timestep embedding kernel

danbev · danbev · commit b55c19435c6f · 2025-09-16T09:15:37.000+02:00
This commit fixes the zero padding for odd dimensions in
the timestep embedding kernel
diff --git a/ggml/src/ggml-metal/ggml-metal.metal b/ggml/src/ggml-metal/ggml-metal.metal
@@ -4167,7 +4167,7 @@ kernel void kernel_timestep_embedding_f32(
     }
 
     if (args.dim % 2 != 0 && tpitg.x == 0) {
-        embed_data[args.dim] = 0.f;
+        embed_data[2 * half_] = 0.f;
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -4167,7 +4167,7 @@ kernel void kernel_timestep_embedding_f32(`
`4167`	`4167`	`}`
`4168`	`4168`
`4169`	`4169`	`if (args.dim % 2 != 0 && tpitg.x == 0) {`
`4170`		`- embed_data[args.dim] = 0.f;`
	`4170`	`+ embed_data[2 * half_] = 0.f;`
`4171`	`4171`	`}`
`4172`	`4172`	`}`
`4173`	`4173`