Skip to content

Commit baf3517

Browse files
committed
llama : use TargetConditionals.h for visionOS/tvOS
1 parent 69a6d36 commit baf3517

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

build-xcframework.sh

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -432,8 +432,8 @@ cmake -B build-visionos -G Xcode \
432432
-DCMAKE_SYSTEM_NAME=visionOS \
433433
-DCMAKE_OSX_SYSROOT=xros \
434434
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=xros \
435-
-DCMAKE_C_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short -DGGML_VISIONOS=1 ${COMMON_C_FLAGS}" \
436-
-DCMAKE_CXX_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short -DGGML_VISIONOS=1 ${COMMON_CXX_FLAGS}" \
435+
-DCMAKE_C_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short ${COMMON_C_FLAGS}" \
436+
-DCMAKE_CXX_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short ${COMMON_CXX_FLAGS}" \
437437
-S .
438438
cmake --build build-visionos --config Release -- -quiet
439439

@@ -445,8 +445,8 @@ cmake -B build-visionos-sim -G Xcode \
445445
-DCMAKE_SYSTEM_NAME=visionOS \
446446
-DCMAKE_OSX_SYSROOT=xrsimulator \
447447
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=xrsimulator \
448-
-DCMAKE_C_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short -DGGML_VISIONOS=1 ${COMMON_C_FLAGS}" \
449-
-DCMAKE_CXX_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short -DGGML_VISIONOS=1 ${COMMON_CXX_FLAGS}" \
448+
-DCMAKE_C_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short ${COMMON_C_FLAGS}" \
449+
-DCMAKE_CXX_FLAGS="-D_XOPEN_SOURCE=700 -Du_int=unsigned\ int -Du_char=unsigned\ char -Du_short=unsigned\ short ${COMMON_CXX_FLAGS}" \
450450
-S .
451451
cmake --build build-visionos-sim --config Release -- -quiet
452452

@@ -460,8 +460,8 @@ cmake -B build-tvos-sim -G Xcode \
460460
-DCMAKE_OSX_ARCHITECTURES="arm64;x86_64" \
461461
-DGGML_METAL=ON \
462462
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=appletvsimulator \
463-
-DCMAKE_C_FLAGS="-DGGML_TVOS=1 ${COMMON_C_FLAGS}" \
464-
-DCMAKE_CXX_FLAGS="-DGGML_TVOS=1 ${COMMON_CXX_FLAGS}" \
463+
-DCMAKE_C_FLAGS="${COMMON_C_FLAGS}" \
464+
-DCMAKE_CXX_FLAGS="${COMMON_CXX_FLAGS}" \
465465
-S .
466466
cmake --build build-tvos-sim --config Release -- -quiet
467467

@@ -474,8 +474,8 @@ cmake -B build-tvos-device -G Xcode \
474474
-DCMAKE_OSX_ARCHITECTURES="arm64" \
475475
-DGGML_METAL=ON \
476476
-DCMAKE_XCODE_ATTRIBUTE_SUPPORTED_PLATFORMS=appletvos \
477-
-DCMAKE_C_FLAGS="-DGGML_TVOS=1 ${COMMON_C_FLAGS}" \
478-
-DCMAKE_CXX_FLAGS="-DGGML_TVOS=1 ${COMMON_CXX_FLAGS}" \
477+
-DCMAKE_C_FLAGS="${COMMON_C_FLAGS}" \
478+
-DCMAKE_CXX_FLAGS="${COMMON_CXX_FLAGS}" \
479479
-S .
480480
cmake --build build-tvos-device --config Release -- -quiet
481481

src/llama-mmap.cpp

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,10 @@
3434
#include <io.h>
3535
#endif
3636

37+
#if defined(__APPLE__)
38+
#include <TargetConditionals.h>
39+
#endif
40+
3741
// TODO: consider moving to llama-impl.h if needed in more places
3842
#if defined(_WIN32)
3943
static std::string llama_format_win_err(DWORD err) {
@@ -471,9 +475,9 @@ struct llama_mlock::impl {
471475

472476
char* errmsg = std::strerror(errno);
473477
bool suggest = (errno == ENOMEM);
474-
#if defined(GGML_VISIONOS) || defined(GGML_TVOS)
475-
// visionOS/watchOS/tvOS dont't support RLIMIT_MEMLOCK
476-
// Skip resource limit checks on visionOS/watchOS/tvOS
478+
#if defined(TARGET_OS_VISION) || defined(TARGET_OS_TV)
479+
// visionOS/tvOS dont't support RLIMIT_MEMLOCK
480+
// Skip resource limit checks on visionOS/tvOS
477481
suggest = false;
478482
#else
479483
struct rlimit lock_limit;

0 commit comments

Comments
 (0)