fix vulkan sgd

graehl · graehl · commit bb6d2e7e8413 · 2025-08-12T18:18:49.000-07:00
diff --git a/ggml/src/ggml-vulkan/vulkan-shaders/opt_step_sgd.comp b/ggml/src/ggml-vulkan/vulkan-shaders/opt_step_sgd.comp
@@ -1,9 +1,6 @@
 #version 450
 
 #include "generic_head.comp"
-#include "types.comp"
-
-#extension GL_EXT_control_flow_attributes : enable
 
 layout(local_size_x = 512, local_size_y = 1, local_size_z = 1) in;
 
@@ -19,7 +16,7 @@ void main() {
     }
 
     const float alpha = data_params[0];
-    const float keep  = data_params[1];
+    const float keep = 1.f - alpha * data_params[1];
 
     data_x[i] = data_x[i] * keep - alpha * data_grad[i];
 }

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,6 @@`
`1`	`1`	`#version 450`
`2`	`2`
`3`	`3`	`#include "generic_head.comp"`
`4`		`-#include "types.comp"`
`5`		`-`
`6`		`-#extension GL_EXT_control_flow_attributes : enable`
`7`	`4`
`8`	`5`	`layout(local_size_x = 512, local_size_y = 1, local_size_z = 1) in;`
`9`	`6`
`@@ -19,7 +16,7 @@ void main() {`
`19`	`16`	`}`
`20`	`17`
`21`	`18`	`const float alpha = data_params[0];`
`22`		`- const float keep = data_params[1];`
	`19`	`+ const float keep = 1.f - alpha * data_params[1];`
`23`	`20`
`24`	`21`	`data_x[i] = data_x[i] * keep - alpha * data_grad[i];`
`25`	`22`	`}`