Skip to content

Commit bd17bc4

Browse files
committed
cleanup
1 parent f5a15fc commit bd17bc4

File tree

1 file changed

+16
-22
lines changed

1 file changed

+16
-22
lines changed

ggml/src/ggml-vulkan/vulkan-shaders/dequant_funcs.comp

Lines changed: 16 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,12 @@ layout (binding = 0) readonly buffer A_PACKED32 {A_TYPE_PACKED32 data_a_packed32
1515
vec2 dequantize(uint ib, uint iqs, uint a_offset) {
1616
return vec2(data_a[a_offset + ib], data_a[a_offset + ib + 1]);
1717
}
18-
vec2 get_dm(uint ib, uint a_offset) {
19-
return vec2(0, 0);
20-
}
2118
#endif
2219

2320
#if defined(DATA_A_F16)
2421
vec2 dequantize(uint ib, uint iqs, uint a_offset) {
2522
return vec2(data_a[a_offset + ib], data_a[a_offset + ib + 1]);
2623
}
27-
vec2 get_dm(uint ib, uint a_offset) {
28-
return vec2(0, 0);
29-
}
3024
#endif
3125

3226
#if defined(DATA_A_Q4_0)
@@ -38,9 +32,6 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
3832
const uint vui = uint(data_a_packed16[a_offset + ib].qs[iqs/2]);
3933
return (vec4(vui & 0xF, (vui >> 4) & 0xF, (vui >> 8) & 0xF, vui >> 12) - 8.0f);
4034
}
41-
vec2 get_dm(uint ib, uint a_offset) {
42-
return vec2(float(data_a[a_offset + ib].d), 0);
43-
}
4435
#endif
4536

4637
#if defined(DATA_A_Q4_1)
@@ -52,9 +43,6 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
5243
const uint vui = uint(data_a_packed16[a_offset + ib].qs[iqs/2]);
5344
return vec4(vui & 0xF, (vui >> 4) & 0xF, (vui >> 8) & 0xF, vui >> 12);
5445
}
55-
vec2 get_dm(uint ib, uint a_offset) {
56-
return vec2(float(data_a[a_offset + ib].d), float(data_a[a_offset + ib].m));
57-
}
5846
#endif
5947

6048
#if defined(DATA_A_Q5_0)
@@ -69,10 +57,7 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
6957
const ivec2 qh0 = ivec2(((uint_qh >> iqs) << 4) & 0x10, (uint_qh >> (iqs + 12)) & 0x10);
7058
const ivec2 qh1 = ivec2(((uint_qh >> (iqs + 1)) << 4) & 0x10, (uint_qh >> (iqs + 13)) & 0x10);
7159
const uint vui = uint(data_a_packed16[a_offset + ib].qs[iqs/2]);
72-
return (vec4(((vui >> 0) & 0xF) | qh0.x, ((vui >> 4) & 0xF) | qh0.y, ((vui >> 8) & 0xF) | qh1.x, (vui >> 12) | qh1.y) - 16.0f);
73-
}
74-
vec2 get_dm(uint ib, uint a_offset) {
75-
return vec2(float(data_a[a_offset + ib].d), 0);
60+
return (vec4((vui & 0xF) | qh0.x, ((vui >> 4) & 0xF) | qh0.y, ((vui >> 8) & 0xF) | qh1.x, (vui >> 12) | qh1.y) - 16.0f);
7661
}
7762
#endif
7863

@@ -90,9 +75,6 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
9075
const uint vui = uint(data_a_packed16[a_offset + ib].qs[iqs/2]);
9176
return vec4(((vui >> 0) & 0xF) | qh0.x, ((vui >> 4) & 0xF) | qh0.y, ((vui >> 8) & 0xF) | qh1.x, (vui >> 12) | qh1.y);
9277
}
93-
vec2 get_dm(uint ib, uint a_offset) {
94-
return vec2(float(data_a[a_offset + ib].d), float(data_a[a_offset + ib].m));
95-
}
9678
#endif
9779

9880
#if defined(DATA_A_Q8_0)
@@ -104,9 +86,6 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
10486
uint32_t v1 = data_a_packed16[a_offset + ib].qs[iqs/2 + 1];
10587
return vec4(int8_t(v0 & 0xFF), int8_t(v0 >> 8), int8_t(v1 & 0xFF), int8_t(v1 >> 8));
10688
}
107-
vec2 get_dm(uint ib, uint a_offset) {
108-
return vec2(float(data_a[a_offset + ib].d), 0);
109-
}
11089
#endif
11190

11291
#if defined(DATA_A_IQ4_NL)
@@ -118,7 +97,22 @@ vec4 dequantize4(uint ib, uint iqs, uint a_offset) {
11897
const uint vui = uint(data_a_packed16[a_offset + ib].qs[iqs/2]);
11998
return vec4(kvalues_iq4nl[vui & 0xF], kvalues_iq4nl[(vui >> 4) & 0xF], kvalues_iq4nl[(vui >> 8) & 0xF], kvalues_iq4nl[vui >> 12]);
12099
}
100+
#endif
101+
102+
#if defined(DATA_A_F32) || defined(DATA_A_F16)
103+
vec2 get_dm(uint ib, uint a_offset) {
104+
return vec2(0, 0);
105+
}
106+
#endif
107+
108+
#if defined(DATA_A_Q4_0) || defined(DATA_A_Q5_0) || defined(DATA_A_Q8_0) || defined(DATA_A_IQ4_NL)
121109
vec2 get_dm(uint ib, uint a_offset) {
122110
return vec2(float(data_a[a_offset + ib].d), 0);
123111
}
124112
#endif
113+
114+
#if defined(DATA_A_Q4_1) || defined(DATA_A_Q5_1)
115+
vec2 get_dm(uint ib, uint a_offset) {
116+
return vec2(float(data_a[a_offset + ib].d), float(data_a[a_offset + ib].m));
117+
}
118+
#endif

0 commit comments

Comments
 (0)