Skip to content

Commit bdedfc1

Browse files
committed
SimpleChatTC: ToolCalling enabled, Sliding window adjust
Chances are for ai models which dont support tool calling, things will be such that the tool calls meta data shared will be silently ignored without much issue. So enabling tool calling feature by default, so that in case one is using a ai model with tool calling the feature is readily available for use. Revert SlidingWindow ChatHistory in Context from last 10 to last 5 (2 more then origianl, given more context support in todays models) by default, given that now tool handshakes go through the tools related side channel in the http handshake and arent morphed into normal user-assistant channel of the handshake.
1 parent 5132835 commit bdedfc1

File tree

2 files changed

+12
-2
lines changed

2 files changed

+12
-2
lines changed

tools/server/public_simplechat/readme.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -589,6 +589,16 @@ SimpleProxy
589589
the whitelist inturn picked from config json
590590
* Helpers to fetch file from local file system or the web, transparently
591591

592+
Chances are for ai models which dont support tool calling, things will be such that the tool calls
593+
meta data shared will be silently ignored without much issue. So enabling tool calling feature by default,
594+
so that in case one is using a ai model with tool calling the feature is readily available for use.
595+
596+
Revert SlidingWindow ChatHistory in Context from last 10 to last 5 (rather 2 more then origianl,
597+
given more context support in todays models) by default, given that now tool handshakes go through
598+
the tools related side channel in the http handshake and arent morphed into normal user-assistant
599+
channel of the handshake.
600+
601+
592602
#### ToDo
593603

594604
Is the tool call promise land trap deep enough, need to think through and explore around this once later.

tools/server/public_simplechat/simplechat.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1304,7 +1304,7 @@ class Me {
13041304
this.defaultChatIds = [ "Default", "Other" ];
13051305
this.multiChat = new MultiChatUI();
13061306
this.tools = {
1307-
enabled: false,
1307+
enabled: true,
13081308
proxyUrl: "http://127.0.0.1:3128",
13091309
proxyAuthInsecure: "NeverSecure",
13101310
searchUrl: SearchURLS.duckduckgo,
@@ -1328,7 +1328,7 @@ class Me {
13281328
this.chatProps = {
13291329
apiEP: ApiEP.Type.Chat,
13301330
stream: true,
1331-
iRecentUserMsgCnt: 10,
1331+
iRecentUserMsgCnt: 5,
13321332
bCompletionFreshChatAlways: true,
13331333
bCompletionInsertStandardRolePrefix: false,
13341334
bTrimGarbage: true,

0 commit comments

Comments
 (0)