Skip to content

Commit c4dcdcc

Browse files
committed
build: fix the cache keys for Windows HIP release job
Update the cache keys to include the HIP SDK version, preventing the use of outdated ROCm installation caches.
1 parent 918b26f commit c4dcdcc

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

.github/workflows/release.yml

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -529,6 +529,11 @@ jobs:
529529
windows-hip:
530530
runs-on: windows-2022
531531

532+
env:
533+
# The ROCm version must correspond to the version used in the HIP SDK.
534+
ROCM_VERSION: "6.4.2"
535+
HIPSDK_INSTALLER_VERSION: "25.Q3"
536+
532537
strategy:
533538
matrix:
534539
include:
@@ -543,21 +548,19 @@ jobs:
543548
- name: Clone rocWMMA repository
544549
id: clone_rocwmma
545550
run: |
546-
git clone https://github.com/rocm/rocwmma --branch rocm-6.2.4 --depth 1
551+
git clone https://github.com/rocm/rocwmma --branch rocm-${{ env.ROCM_VERSION }} --depth 1
547552
548553
- name: Cache ROCm Installation
549554
id: cache-rocm
550555
uses: actions/cache@v4
551556
with:
552557
path: C:\Program Files\AMD\ROCm
553-
key: rocm-6.1-${{ runner.os }}-v1
554-
restore-keys: |
555-
rocm-6.1-${{ runner.os }}-
558+
key: rocm-${{ env.HIPSDK_INSTALLER_VERSION }}-${{ runner.os }}
556559

557560
- name: ccache
558561
uses: ggml-org/[email protected]
559562
with:
560-
key: windows-latest-cmake-hip-${{ matrix.name }}-x64
563+
key: windows-latest-cmake-hip-${{ env.HIPSDK_INSTALLER_VERSION }}-${{ matrix.name }}-x64
561564
evict-old-files: 1d
562565

563566
- name: Install ROCm
@@ -566,7 +569,7 @@ jobs:
566569
run: |
567570
$ErrorActionPreference = "Stop"
568571
write-host "Downloading AMD HIP SDK Installer"
569-
Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-25.Q3-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe"
572+
Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-${{ env.HIPSDK_INSTALLER_VERSION }}-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe"
570573
write-host "Installing AMD HIP SDK"
571574
$proc = Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -PassThru
572575
$completed = $proc.WaitForExit(600000)

0 commit comments

Comments
 (0)