Skip to content

Commit e159e77

Browse files
committed
cmake : disable -Wshadow for GCC
ggml-ci
1 parent 9a735ae commit e159e77

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

cmake/common.cmake

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,12 @@ function(llama_add_compile_flags)
1313
list(APPEND C_FLAGS -Wshadow -Wstrict-prototypes -Wpointer-arith -Wmissing-prototypes
1414
-Werror=implicit-int -Werror=implicit-function-declaration)
1515

16-
list(APPEND CXX_FLAGS -Wshadow -Wmissing-declarations -Wmissing-noreturn)
16+
list(APPEND CXX_FLAGS -Wmissing-declarations -Wmissing-noreturn)
17+
18+
# GCC -Wshadow is way too agressive
19+
if (CMAKE_CXX_COMPILER_ID STREQUAL "Clang")
20+
list(APPEND CXX_FLAGS -Wshadow)
21+
endif()
1722

1823
list(APPEND WARNING_FLAGS -Wall -Wextra -Wpedantic -Wcast-qual -Wno-unused-function)
1924

0 commit comments

Comments
 (0)