ggml-zdnn: fix pr comments

Signed-off-by: Aaron Teo <[email protected]>

Author: taronaeo

ggml/src/ggml-zdnn/CMakeLists.txt

@@ -1,38 +1,36 @@
-if (GGML_ZDNN)
-    if (DEFINED ZDNN_ROOT)
-        message(STATUS "zdnn: using ZDNN_ROOT override: ${ZDNN_ROOT}")
-        set(ZDNN_HINT "${ZDNN_ROOT}")
-    else()
-        set(ZDNN_HINT "")
-    endif()
+if (DEFINED ZDNN_ROOT)
+    message(STATUS "zdnn: using ZDNN_ROOT override: ${ZDNN_ROOT}")
+    set(ZDNN_HINT "${ZDNN_ROOT}")
+else()
+    set(ZDNN_HINT "")
+endif()
 
-    find_path(ZDNN_INCLUDE
-              NAMES zdnn.h
-              HINTS ${ZDNN_HINT} /usr /usr/local
-              PATH_SUFFIXES include)
-    if (ZDNN_INCLUDE)
-        message(STATUS "zdnn: found include: ${ZDNN_INCLUDE}")
-    else()
-        message(FATAL_ERROR "zdnn: include directory not found, please set ZDNN_ROOT to the proper path if necessary")
-    endif()
+find_path(ZDNN_INCLUDE
+            NAMES zdnn.h
+            HINTS ${ZDNN_HINT} /usr /usr/local
+            PATH_SUFFIXES include)
+if (ZDNN_INCLUDE)
+    message(STATUS "zdnn: found include: ${ZDNN_INCLUDE}")
+else()
+    message(FATAL_ERROR "zdnn: include directory not found, please set ZDNN_ROOT to the proper path if necessary")
+endif()
 
-    find_library(ZDNN_LIB
-                 NAMES zdnn
-                 HINTS ${ZDNN_HINT} /usr /usr/local
-                 PATH_SUFFIXES lib lib64)
-    if (ZDNN_LIB)
-        message(STATUS "zdnn: found library: ${ZDNN_LIB}")
-    else()
-        message(FATAL_ERROR "zdnn: library not found, please set ZDNN_ROOT to the proper path if necessary")
-    endif()
+find_library(ZDNN_LIB
+                NAMES zdnn
+                HINTS ${ZDNN_HINT} /usr /usr/local
+                PATH_SUFFIXES lib lib64)
+if (ZDNN_LIB)
+    message(STATUS "zdnn: found library: ${ZDNN_LIB}")
+else()
+    message(FATAL_ERROR "zdnn: library not found, please set ZDNN_ROOT to the proper path if necessary")
+endif()
 
-    file(GLOB GGML_SOURCES_ZDNN "*.c" "*.cpp")
-    file(GLOB GGML_HEADERS_ZDNN "*.h" "*.hpp")
+file(GLOB GGML_SOURCES_ZDNN "*.c" "*.cpp")
+file(GLOB GGML_HEADERS_ZDNN "*.h" "*.hpp")
 
-    ggml_add_backend_library(ggml-zdnn ${GGML_HEADERS_ZDNN} ${GGML_SOURCES_ZDNN})
-    target_link_libraries(ggml-zdnn PRIVATE ${ZDNN_LIB})
-    target_include_directories(ggml-zdnn PRIVATE ${ZDNN_INCLUDE})
-    target_link_directories(ggml-zdnn PRIVATE ${ZDNN_LIB})
+ggml_add_backend_library(ggml-zdnn ${GGML_HEADERS_ZDNN} ${GGML_SOURCES_ZDNN})
+target_link_libraries(ggml-zdnn PRIVATE ${ZDNN_LIB})
+target_include_directories(ggml-zdnn PRIVATE ${ZDNN_INCLUDE})
+target_link_directories(ggml-zdnn PRIVATE ${ZDNN_LIB})
 
-    target_compile_definitions(ggml-zdnn PRIVATE GGML_ZDNN GGML_USE_ZDNN)
-endif()
+target_compile_definitions(ggml-zdnn PRIVATE GGML_ZDNN GGML_USE_ZDNN)

ggml/src/ggml-zdnn/ggml-zdnn.cpp

@@ -287,8 +287,6 @@ static bool ggml_zdnn_supports_op(const ggml_backend_zdnn_device_context * ctx_d
         default:
             return false;
     }
-
-    GGML_UNUSED(ctx_dev);
 }
 
 ////////////////////////////////////////////////////////////////////////////////