correct test if vec_dot_type == GGML_TYPE_F32

Author: Djip007

tests/test-quantize-fns.cpp

@@ -86,10 +86,15 @@ static float dot_product_error(
     const auto * vdot = ggml_get_type_traits(qfns->vec_dot_type);
 
     qfns->from_float(test_data1, tmp_q1.data(), test_size);
-    vdot->from_float(test_data2, tmp_q2.data(), test_size);
+    if (qfns->vec_dot_type != GGML_TYPE_F32)
+        vdot->from_float(test_data2, tmp_q2.data(), test_size);
 
     float result = INFINITY;
-    qfns->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, 1);
+    if (qfns->vec_dot_type != GGML_TYPE_F32) {
+        qfns->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, tmp_q2.data(), 0, 1);
+    } else {
+        qfns->vec_dot(test_size, &result, 0, tmp_q1.data(), 0, test_data2, 0, 1);
+    }
 
     const float dot_ref = dot_product(test_data1, test_data2, test_size);
 

tests/test-quantize-perf.cpp

@@ -323,7 +323,7 @@ int main(int argc, char * argv[]) {
                 printf("\n");
             }
 
-            if (params.op_quantize_row_q_dot) {
+            if (params.op_quantize_row_q_dot && ggml_get_type_traits(qfns->vec_dot_type)->from_float) {
                 printf("  quantize_row_q_dot\n");
                 for (size_t size : params.test_sizes) {
                     printf("    %zu values (%.2f MB)\n", size, 4*size/(float)(1024*1024));