Skip to content

Commit f54c96e

Browse files
committed
kompute: op_mul_mat_f16 permutted support
Signed-off-by: Sergio Lopez <[email protected]>
1 parent 9c5bdf4 commit f54c96e

File tree

2 files changed

+12
-9
lines changed

2 files changed

+12
-9
lines changed

ggml/src/ggml-kompute/ggml-kompute.cpp

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -916,9 +916,9 @@ static void ggml_vk_mul_mat_f16(
916916
const std::shared_ptr<kp::Tensor>& out,
917917
uint32_t inAOff, uint32_t inBOff, uint32_t outOff,
918918
int32_t ne00, int32_t ne01, int32_t ne02,
919-
uint32_t nb00, uint32_t nb01, uint32_t nb02,
919+
uint32_t nb00, uint32_t nb01, uint32_t nb02, uint32_t nb03,
920920
int32_t ne10, int32_t ne11, int32_t ne12, int32_t ne13,
921-
uint32_t nb10, uint32_t nb11, uint32_t nb12,
921+
uint32_t nb10, uint32_t nb11, uint32_t nb12, uint32_t nb13,
922922
int32_t ne0, int32_t ne1,
923923
uint32_t r2, uint32_t r3
924924
) {
@@ -928,17 +928,17 @@ static void ggml_vk_mul_mat_f16(
928928
struct PushConstants {
929929
uint32_t inAOff, inBOff, outOff;
930930
int32_t ne00, ne01, ne02;
931-
uint32_t nb00, nb01, nb02;
931+
uint32_t nb00, nb01, nb02, nb03;
932932
int32_t ne10, ne11, ne12;
933-
uint32_t nb10, nb11, nb12;
933+
uint32_t nb10, nb11, nb12, nb13;
934934
int32_t ne0, ne1;
935935
uint32_t r2, r3;
936936
} pushConsts {
937937
safe_divide(inAOff, 2), safe_divide(inBOff, 4), safe_divide(outOff, 4),
938938
ne00, ne01, ne02,
939-
nb00, nb01, nb02,
939+
nb00, nb01, nb02, nb03,
940940
ne10, ne11, ne12,
941-
nb10, nb11, nb12,
941+
nb10, nb11, nb12, nb13,
942942
ne0, ne1,
943943
r2, r3
944944
};
@@ -1693,7 +1693,8 @@ static void ggml_vk_graph_compute(struct ggml_kompute_context * ctx, struct ggml
16931693
case GGML_TYPE_F16:
16941694
ggml_vk_mul_mat_f16(
16951695
seq, id_src0, id_src1, id_dst, off_src0, off_src1, off_dst,
1696-
ne00, ne01, ne02, nb00, nb01, nb02, ne10, ne11, ne12, ne13, nb10, nb11, nb12,
1696+
ne00, ne01, ne02, nb00, nb01, nb02, nb03,
1697+
ne10, ne11, ne12, ne13, nb10, nb11, nb12, nb13,
16971698
ne0, ne1, r2, r3
16981699
);
16991700
break;

ggml/src/ggml-kompute/kompute-shaders/op_mul_mat_f16.comp

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,14 @@ layout (push_constant) uniform parameter {
2020
uint nb00;
2121
uint nb01;
2222
uint nb02;
23+
uint nb03;
2324
int ne10;
2425
int ne11;
2526
int ne12;
2627
uint nb10;
2728
uint nb11;
2829
uint nb12;
30+
uint nb13;
2931
int ne0;
3032
int ne1;
3133
uint r2;
@@ -42,7 +44,7 @@ void main() {
4244
const uint i12 = im%pcs.ne12;
4345
const uint i13 = im/pcs.ne12;
4446

45-
const uint offset0 = r0*pcs.nb01 + (i12/pcs.r2)*pcs.nb02 + (i13/pcs.r3)*pcs.nb02*pcs.ne02;
47+
const uint offset0 = r0*pcs.nb01 + (i12/pcs.r2)*pcs.nb02 + (i13/pcs.r3)*pcs.nb03;
4648

4749
const uint x = offset0 / 2 + pcs.inAOff; // Based from inA
4850

@@ -52,7 +54,7 @@ void main() {
5254
break;
5355
}
5456

55-
const uint y = (r1*pcs.nb11 + im*pcs.nb12) / 4 + pcs.inBOff; // Based from inB
57+
const uint y = (r1*pcs.nb11 + i12*pcs.nb12 + i13*pcs.nb13) / 4 + pcs.inBOff;
5658

5759
float sumf = 0;
5860
for (uint i = gl_SubgroupInvocationID.x; i < pcs.ne00; i += gl_SubgroupSize) {

0 commit comments

Comments
 (0)