Skip to content

Commit f66d799

Browse files
committed
Address PR comments: clean up comments
1 parent 6d0c2d8 commit f66d799

File tree

3 files changed

+1
-3
lines changed

3 files changed

+1
-3
lines changed

ggml/src/ggml-sycl/ggml-sycl.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3106,7 +3106,6 @@ static void reorder_qw_q6_k(uint8_t * data_device, size_t size, size_t offset, d
31063106

31073107
auto * ql_ptr = data_device;
31083108
auto * qh_ptr = ql_ptr + (QK_K / 2) * nblocks;
3109-
// scales are after all quants' bits so adding both to get correct offset
31103109
auto * scales_ptr = qh_ptr + (QK_K / 4) * nblocks;
31113110
sycl::half * dm_ptr = (sycl::half *) (scales_ptr + (QK_K / 16) * nblocks);
31123111

ggml/src/ggml-sycl/mmvq.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ static void mul_mat_vec_q_reorder(const void * __restrict__ vx, const void * __r
3232
float partial_sum = 0.0f;
3333
for (int i = sg.get_local_linear_id() / block_elements_per_subgroup; i < blocks_per_row; i += blocks_per_subgroup) {
3434
const int ibx = row * blocks_per_row + i; // x block index
35-
// TODO: Generalize offsets, right now only works for quantizations that don't split high and low bits
35+
3636
const auto bx_offset = block_type::get_block_offset(ibx, nblocks);
3737
const auto d_offset = block_type::get_d_offset(nrows, ncols, ibx);
3838
// Y block index that aligns with ibx

ggml/src/ggml-sycl/vecdotq.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -403,7 +403,6 @@ template <> struct reorder_vec_dot_q_sycl<GGML_TYPE_Q6_K> {
403403
using q6_k_block = ggml_sycl_reordered::block_q_t<GGML_TYPE_Q6_K>;
404404
using q6_k_traits = typename q6_k_block::traits;
405405

406-
// contiguous v/x values
407406
__dpct_inline__ float vec_dot_q6_K_q8_1_impl_mmvq(const int & vl, const int & vh, const int * __restrict__ u,
408407
const int8_t * __restrict__ scales, const float d,
409408
const float * __restrict__ d8) {

0 commit comments

Comments
 (0)