Skip to content

Conversation

@VJHack
Copy link
Contributor

@VJHack VJHack commented Nov 1, 2024

This PR fixes bug #9933. When n_predict is set to -2, generation will occur until the context is filled. Some basic server tests were added to demonstrate functionality.

@github-actions github-actions bot added examples python python script changes server labels Nov 1, 2024
@VJHack VJHack changed the title Server: generate until context is filled Server: handle generation until context is filled Nov 1, 2024
@VJHack VJHack mentioned this pull request Nov 1, 2024
4 tasks
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't want to discourage new people to make contributions to the project. But to be honest, coding style in this PR does not even meet the minimum requirement of this project. You should probably take more time to read the code.

@VJHack
Copy link
Contributor Author

VJHack commented Nov 23, 2024

I don't want to discourage new people to make contributions to the project. But to be honest, coding style in this PR does not even meet the minimum requirement of this project. You should probably take more time to read the code.

I appreciate you taking the time to review my work. I'm new to this project and am still working on my coding style. Your feedback definitely helped a lot. I'll be more careful in my future contributions. Thank you!

@VJHack VJHack requested a review from ngxson November 23, 2024 04:53
@VJHack VJHack marked this pull request as draft December 27, 2024 21:44
@VJHack VJHack closed this Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

examples python python script changes server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants