Skip to content

swift : exclude ggml-metal-embed.metal #10211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 8, 2024
Merged

swift : exclude ggml-metal-embed.metal #10211

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2516e8c
llama.swift : exclude ggml-metal-embed.metal
jhen0409 Nov 8, 2024
0391434
swift : exclude build/
jhen0409 Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,8 @@ let package = Package(
"models",
"tests",
"CMakeLists.txt",
"Makefile"
"Makefile",
"ggml/src/ggml-metal-embed.metal"
Copy link
Member

@danbev danbev Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there might be a similar issue with the cmake build. I think something like this might work for cmake if you'd like to add it:

diff --git a/Package.swift b/Package.swift
index d246658b..8a064fd8 100644
--- a/Package.swift
+++ b/Package.swift
@@ -68,7 +68,9 @@ let package = Package(
                "tests",
                "CMakeLists.txt",
                "Makefile",
-               "ggml/src/ggml-metal-embed.metal"
+               "ggml/src/ggml-metal-embed.metal",
+               "./build/autogenerated/ggml-metal-embed.metal",
+               "./build/bin/ggml-metal.metal"
             ],
             sources: sources,
             resources: resources,

],
sources: sources,
resources: resources,
Expand Down
Loading