Skip to content

simple-chat : fix BOS being added to each message #11278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2025
Merged

simple-chat : fix BOS being added to each message #11278

merged 1 commit into from
Jan 19, 2025

Conversation

@ggerganov
Copy link
Member

Noticed that the existing logic of llama-simple-chat adds BOS token at the start of each chat message, which is generally incorrect.

This is a sample fix, though probably a better fix could be implemented.

Repro:

make -j && ./bin/llama-simple-chat -m ../models/llama-8b-v3-instruct/ggml-model-f16.gguf 

> Hello
Hello! It's nice to meet you. Is there something I can help you with, or would you like to chat?
> Count to 3
1, 2, 3!

(on master this does not produce a reply on the second message)

@ggerganov ggerganov requested a review from slaren January 17, 2025 10:34
@ggerganov ggerganov marked this pull request as ready for review January 17, 2025 12:10
ericcurtin
ericcurtin approved these changes Jan 17, 2025
View reviewed changes
Copy link
Collaborator

@ericcurtin ericcurtin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs to go in run.cpp also, it got carried over from here

@ggerganov ggerganov merged commit b9daaff into master Jan 19, 2025
48 checks passed
@ggerganov ggerganov deleted the gg/simple-chat-fix-bos branch January 19, 2025 16:12
@ericcurtin
Copy link
Collaborator

#11302

anagri pushed a commit to BodhiSearch/llama.cpp that referenced this pull request Jan 26, 2025
@ggerganov @anagri
simple-chat : fix BOS being added to each message (ggml-org#11278)
47874a1
tinglou pushed a commit to tinglou/llama.cpp that referenced this pull request Feb 13, 2025
@ggerganov @tinglou
simple-chat : fix BOS being added to each message (ggml-org#11278)
5e4ae35
arthw pushed a commit to arthw/llama.cpp that referenced this pull request Feb 26, 2025
@ggerganov @NeoZhangJianyu
simple-chat : fix BOS being added to each message (ggml-org#11278)
aebee76
mglambda pushed a commit to mglambda/llama.cpp that referenced this pull request Mar 8, 2025
@ggerganov @mglambda
simple-chat : fix BOS being added to each message (ggml-org#11278)
7ac061a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slaren slaren slaren approved these changes

@ngxson ngxson ngxson approved these changes

+1 more reviewer

@ericcurtin ericcurtin ericcurtin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

examples

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggerganov @ericcurtin @slaren @ngxson