Fix #11802: Compile bug - RegQueryValueExA changed to RegQueryValueEx

[sheldonrobinson]

Make sure to read the contributing guidelines before submitting a PR

fix #11802

[slaren]

Won't this cause the value to be read as a wchar_t as well? I believe the correct solution here would be to continue using RegQueryValueA, but remove the use of the TEXT macro to pass the key name.

[sheldonrobinson]

The TEXT is also handled. If UNICODE, TEXT is L##, other TEXT is ANSI string. See TEXT macro (winnt.h)

[slaren]

RegQueryValueExA always takes an ANSI string (that's what the A suffix means), so there is no need to use the TEXT macro here.

[sheldonrobinson]

See also
If UNICODE, then #define __TEXT(quote) L##quote
else
#define __TEXT(quote) quote
and
#define TEXT(quote) __TEXT(quote)

[sheldonrobinson]

It should be RegQueryValueEx and TEXT.

[slaren]

This is getting tiring. We cannot use the UNICODE version of this function because the string read is expected to be in ANSI format. For this reason we need to use RegQueryValueExA always, because RegQueryValueExW will return an UNICODE string. However, because we are using RegQueryValueExA, the TEXT macro is not necessary here.

[sheldonrobinson]

Ok, agreed. Keep RegQueryValueExA, remove TEXT

[slaren]

Thanks.