HIP: workaround runtime bug in hipGraph support #11964
Closed
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
IMbackK
force-pushed
the
fix_hipgraph
branch
from
6e3d584 to
dbf12a6
Compare
IMbackK
force-pushed
the
fix_hipgraph
branch
from
dbf12a6 to
747ec37
Compare
slaren
approved these changes
Feb 19, 2025
Collaborator
Author
|
after some additional discussion in ROCm/clr#138 it seams to me like the lamacpp code and the cuda runtime is also broken and its a bit unclear how this is supposed to work in the first place as the ownership of the memory is quite unclear given the available documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds a workaround for #11949. Once ROCm/clr#138 is fixed this will add a memory leak, i promise to restrict the workaround to versions with the bug as soon as a release fixing the underlying issue is released.