Skip to content

Conversation

@vynride
Copy link
Contributor

@vynride vynride commented Feb 26, 2025

  • Fixed typos in webui
  • Renamed the variable 'trimedValue' to 'trimmedValue'
  • Clarified the confirmation box text.

@ngxson
Copy link
Collaborator

ngxson commented Feb 26, 2025

You also need to run npm run build

@vynride
Copy link
Contributor Author

vynride commented Feb 26, 2025

@ngxson can you verify now?

@vynride
Copy link
Contributor Author

vynride commented Feb 27, 2025

@ngxson What exactly is going wrong here?

@ngxson
Copy link
Collaborator

ngxson commented Feb 27, 2025

Which version of nodejs and which OS you're using ?

@vynride
Copy link
Contributor Author

vynride commented Feb 27, 2025

Which version of nodejs and which OS you're using ?

$ node --version
v22.14.0

OS: Windows 11 Pro

@ngxson
Copy link
Collaborator

ngxson commented Feb 27, 2025

I'm not sure, but seems like on Windows the gzip function produces different result than linux/mac

But anw, because you're creating this PR from your master branch, I cannot help you fix it. Try creating from another branch.

This is mentioned in our contribution guide, please read: https://github.com/ggml-org/llama.cpp/blob/master/CONTRIBUTING.md

Consider allowing write access to your branch for faster reviews, as reviewers can push commits directly

@vynride
Copy link
Contributor Author

vynride commented Feb 28, 2025

I'm not sure, but seems like on Windows the gzip function produces different result than linux/mac

I see, I'll get back to you with a fix from Arch linux

But anw, because you're creating this PR from your master branch, I cannot help you fix it. Try creating from another branch.

Sure, in that case, I'll just close this pr and create a new one

@vynride vynride closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants