Adding UTF-8 support to linenoise.cpp #12111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngxson
changed the title
ericcurtin
force-pushed
the
llama-run-utf-8
branch
from
5e8c867 to
ad7a69e
Compare
Collaborator
Author
|
@ngxson PTAL |
ericcurtin
force-pushed
the
llama-run-utf-8
branch
from
ad7a69e to
344e9ae
Compare
For emojis, non-alpha characters, etc. Signed-off-by: Eric Curtin <[email protected]>
ericcurtin
force-pushed
the
llama-run-utf-8
branch
from
344e9ae to
83d7315
Compare
ngxson
approved these changes
Mar 3, 2025
Collaborator
ngxson
left a comment
ngxson
left a comment
There was a problem hiding this comment.
I don't have enough knowledge to review vendor changes, only giving approval so you can merge it.
Collaborator
Author
|
@yhirose this was the end goal for the UTF-8 stuff if you are interested and hence to be used in RamaLama to implement this properly: llama.cpp in general seems to be benefitting greatly from your work with it's usage of cpp-httplib also 😄 |
Collaborator
Author
|
There was also some people who were trying to input japanese characters are such that complained it wasn't being sent to llama.cpp properly from linenoise.cpp , hopefully this is in a better place now. |
|
@ericcurtin sounds good! If you find any problem with the UTF-8 support, please let me know. |
mglambda
pushed a commit
to mglambda/llama.cpp
that referenced
this pull request
Mar 8, 2025
For emojis, non-alpha characters, etc. Signed-off-by: Eric Curtin <[email protected]>
arthw
pushed a commit
to arthw/llama.cpp
that referenced
this pull request
Mar 19, 2025
For emojis, non-alpha characters, etc. Signed-off-by: Eric Curtin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For emojis, non-alpha characters, etc.