CUDA: Fix new mma detection for Turing cards with Volta PTX #12187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
Collaborator
|
Please confirm whether or not #12222 fixes the issue. The fix in this PR is definitely not correct for all scenarios. |
Author
|
#12222 fixes the issue too. Will close this PR in favor of your fix. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are seeing that this change incorrectly disabled flash attention for Turing cards (cc=75) when llama.cpp was compiled for Volta cards only (cc=70). To fix, check that we have compiled for Volta or greater, and that the card is Turing or greater. If there is a better way to fix, please do advise.
To reproduce the breakage on the current build, compile with architecture
70and without architecture75, and generate with flash attention on a Turing card.