feat(CMakeLists): Add MSVC-specific compiler warning flags in CMake configuration #12206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This pull request improves the handling of MSVC compiler warning flags in the CMake build configuration. Previously, the MSVC compiler warning flags (
C_FLAGSandCXX_FLAGS) were unset, resulting in limited warning coverage. This change explicitly defines and applies a comprehensive set of MSVC warnings for improved code quality and consistency.Key Changes:
C_FLAGSandCXX_FLAGS).MSVC_WARNING_FLAGSwith a clear set of warning flags:/W4: Comprehensive warnings similar to GCC's-Wall./we4456,/we4457,/we4458)./wd4100,/wd4324).Rationale:
Testing:
llama-perplexityandllama-bench).Review Considerations: