cmake: Allow to configure GGML_BUILD_NUMBER with file #12509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will enable llama-cpp-python to generate the file during sdist build and include it into the final tarball. The file then will be picked up by the package build to include the correct version, even without full git checkout included. Related: abetlen/llama-cpp-python#1979 Signed-off-by: Ihar Hrachyshka <[email protected]>
github-actions
bot
added
the
ggml
booxter
added a commit
to booxter/llama-cpp-python
that referenced
this pull request
Mar 22, 2025
With that, builds using tarball will still have the correct cmake package version for ggml. This assumes the file is read by llama.cpp build system, see: ggml-org/llama.cpp#12509 Fixes abetlen#1979 Signed-off-by: Ihar Hrachyshka <[email protected]>
Contributor
Author
|
I won't have time to get it to completion sadly. Feel free to take it over if anyone is interested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will enable llama-cpp-python to generate the file during sdist build and
include it into the final tarball. The file then will be picked up by the
package build to include the correct version, even without full git checkout
included.
Related: abetlen/llama-cpp-python#1979