Skip to content

Conversation

@yeahdongcn
Copy link
Collaborator

Make sure to read the contributing guidelines before submitting a PR

In my previous PR, I intended to enable the Free Disk Space (Ubuntu) step for MUSA. However, the step was still being skipped.

Upon closer look, I realized the issue was caused by a misconfigured key. This PR fixes that by updating the key to free_disk_space to ensure the step is properly activated.

@github-actions github-actions bot added the devops improvements to build systems and github actions label Apr 10, 2025
@ggerganov ggerganov requested a review from ngxson April 11, 2025 07:05
Copy link
Collaborator

@ngxson ngxson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that's right, the related LOC in the file is:

- name: Free Disk Space (Ubuntu)
if: ${{ matrix.config.free_disk_space == true }}

So the correct naming is free_disk_space

@ngxson ngxson merged commit 8ac9f5d into ggml-org:master Apr 11, 2025
2 checks passed
colout pushed a commit to colout/llama.cpp that referenced this pull request Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devops improvements to build systems and github actions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants