From 8765394ea442221e6ed8232161d89b5d0eccfc88 Mon Sep 17 00:00:00 2001 From: Aaron Teo Date: Sat, 12 Apr 2025 21:35:50 +0800 Subject: [PATCH 1/2] llava: fixes #12863 v.head.ffn_up.bias byteswap on BE systems Signed-off-by: Aaron Teo --- examples/llava/convert_image_encoder_to_gguf.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/examples/llava/convert_image_encoder_to_gguf.py b/examples/llava/convert_image_encoder_to_gguf.py index 2949faec421be..5efdcadb23c65 100644 --- a/examples/llava/convert_image_encoder_to_gguf.py +++ b/examples/llava/convert_image_encoder_to_gguf.py @@ -363,6 +363,11 @@ def get_non_negative_vision_feature_layers(v_hparams): else: data = data.squeeze().numpy().astype(np.float32) + # byteswaps v.head.ffn_up.bias for big-endian systems + # see: https://github.com/ggml-org/llama.cpp/issues/12863 + if name == "v.head.ffn_up.bias" and arg.bigendian: + data = data.byteswap(inplace=True) + fout.add_tensor(name, data) print("Projector tensors added\n") From 9ba4b4f03c8658820ec4eb31053fbb994ad514f4 Mon Sep 17 00:00:00 2001 From: Aaron Teo Date: Sat, 12 Apr 2025 21:47:31 +0800 Subject: [PATCH 2/2] llava: fix typo in arg vs args Signed-off-by: Aaron Teo --- examples/llava/convert_image_encoder_to_gguf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/llava/convert_image_encoder_to_gguf.py b/examples/llava/convert_image_encoder_to_gguf.py index 5efdcadb23c65..5920af48023e7 100644 --- a/examples/llava/convert_image_encoder_to_gguf.py +++ b/examples/llava/convert_image_encoder_to_gguf.py @@ -365,7 +365,7 @@ def get_non_negative_vision_feature_layers(v_hparams): # byteswaps v.head.ffn_up.bias for big-endian systems # see: https://github.com/ggml-org/llama.cpp/issues/12863 - if name == "v.head.ffn_up.bias" and arg.bigendian: + if name == "v.head.ffn_up.bias" and args.bigendian: data = data.byteswap(inplace=True) fout.add_tensor(name, data)