rpc : add RPC_CMD_HELLO #12955
Merged
rpc : add RPC_CMD_HELLO #12955
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
examples
ggml
|
@slaren Is there anything else we can do to make this future proof when ggml starts having versions? |
slaren
reviewed
Apr 15, 2025
There was a problem hiding this comment.
I don't think there is a way to make this future-proof for ggml versions at this point because we don't even know how ggml is going to be versioned. However, that shouldn't be a problem because once that is done, you can easily increase the version of the RPC protocol and make any changes that may be necessary.
I would suggest blocking clients that do not send the HELLO packet to prevent older versions from skipping the check entirely.
Add RPC_CMD_HELLO for getting the version of the protocol implemend by the server. Follow the semantic versioning rules at https://semver.org Hopefully this bring better user experience when we make breaking changes at the protocol level and avoid issues like ggml-org#12465
slaren
approved these changes
Apr 17, 2025
colout
pushed a commit
to colout/llama.cpp
that referenced
this pull request
Apr 21, 2025
Add RPC_CMD_HELLO for getting the version of the protocol implemend by the server. Follow the semantic versioning rules at https://semver.org Hopefully this bring better user experience when we make breaking changes at the protocol level and avoid issues like ggml-org#12465
pockers21
pushed a commit
to pockers21/llama.cpp
that referenced
this pull request
Apr 28, 2025
Add RPC_CMD_HELLO for getting the version of the protocol implemend by the server. Follow the semantic versioning rules at https://semver.org Hopefully this bring better user experience when we make breaking changes at the protocol level and avoid issues like ggml-org#12465
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add RPC_CMD_HELLO for getting the version of the protocol implemend by the server. Follow the semantic versioning rules at https://semver.org
Hopefully this bring better user experience when we make breaking changes at the protocol level and avoid issues like #12465