Add Pad Reflect 1D CUDA support #14659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Nvidia GPU
JohannesGaessler
approved these changes
Jul 15, 2025
Collaborator
JohannesGaessler
left a comment
JohannesGaessler
left a comment
There was a problem hiding this comment.
Please tell me whether you want to address the comment regarding the loop in this PR.
| const char * src0_ptr = (const char *)src0 + i3*nb03 + i2*nb02 + i1*nb01; | ||
| char * dst_ptr = (char *)dst + i3*nb3 + i2*nb2 + i1*nb1; | ||
|
|
||
| for (int64_t i0 = threadIdx.x; i0 < ne0; i0 += blockDim.x) { |
Collaborator
There was a problem hiding this comment.
This is going to produce correct results but generally speaking you will get much better performance if each thread just works on a single value instead of looping over ne0. However, it would also be fine to just merge it as-is and maybe change this later if it ever becomes relevant for end-to-end performance.
Co-authored-by: Johannes Gäßler <[email protected]>
4 tasks
Collaborator
|
@YavorGIvanov Shall we merge as-is or are you looking into the review comment by @JohannesGaessler? |
Collaborator
|
@YavorGIvanov ping |
Contributor
Author
|
Let's merge as is. @CISC |
qnixsynapse
pushed a commit
to janhq/llama.cpp
that referenced
this pull request
Aug 25, 2025
* Add Pad Reflect 1D CUDA support * Update ggml/src/ggml-cuda/pad_reflect_1d.cu Co-authored-by: Johannes Gäßler <[email protected]> --------- Co-authored-by: Johannes Gäßler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.