Skip to content

Fix params bug in diffusion example #14993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 31, 2025
Merged

Fix params bug in diffusion example #14993

merged 1 commit into from
Jul 31, 2025

Conversation

@am17an
Copy link
Collaborator

@am17an am17an commented Jul 31, 2025 •
edited
Loading

This causes an assert to trigger because of default params when using --diffusion-eps

llama.cpp/examples/diffusion/diffusion-cli.cpp

Line 616 in d6818d0

GGML_ASSERT((params.diffusion.eps == 0) ^ (params.diffusion.block_length == 0));

@am17an am17an requested a review from CISC July 31, 2025 16:15
@am17an am17an merged commit 7845240 into ggml-org:master Jul 31, 2025
47 checks passed
Nexesenex pushed a commit to Nexesenex/croco.cpp that referenced this pull request Aug 1, 2025
@am17an @Nexesenex
Fix params bug in diffusion example (ggml-org#14993)
58f0509
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CISC CISC CISC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@am17an @CISC