Skip to content

Conversation

@danbev
Copy link
Member

@danbev danbev commented Sep 3, 2025

This commit adds a curl script to the model-conversion examples which is currently missing. This script is required for the running the embedding server targets to test llama-server embeddings functionality.

This commit adds a curl script to the model-conversion examples
which is currently missing. This script is required for the running the
embedding server targets to test llama-server embeddings functionality.
@danbev danbev requested a review from ggerganov September 3, 2025 07:42
@danbev danbev removed the request for review from ggerganov September 3, 2025 07:48
@danbev danbev merged commit 8c3fdf4 into ggml-org:master Sep 3, 2025
1 check passed
@CISC
Copy link
Collaborator

CISC commented Sep 3, 2025

BTW, all the scripts should probably be updated to use /usr/bin/env, also noticed that some of them have incorrect file-endings, like run-casual-gen-embeddings-org.sh, which is a Python script. :)

Edit: Oh, and some even have missing hash-bangs: compare-embeddings-logits.sh, create-collection-add-model.sh...

@danbev
Copy link
Member Author

danbev commented Sep 3, 2025

@CISC Thanks, I'll go through them add fix these issues 👍

@danbev danbev deleted the model-conversion-curl-script branch September 3, 2025 09:47
walidbr pushed a commit to walidbr/llama.cpp that referenced this pull request Sep 7, 2025
This commit adds a curl script to the model-conversion examples
which is currently missing. This script is required for the running the
embedding server targets to test llama-server embeddings functionality.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants