-
Notifications
You must be signed in to change notification settings - Fork 13.7k
sycl: flash-attention implementation #16969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: safranowith <[email protected]> Co-authored-by: ye-NX <[email protected]>
NeoZhangJianyu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meet compile error on https://github.com/ye-NX/llama.cpp/tree/saf-ye/flash-attn:
/home/xxx/hd1/llama.cpp/llama.cpp_saf-ye_flash-attn/ggml/src/ggml-sycl/ggml-sycl.cpp:3843:13: error: use of undeclared identifier 'ggml_sycl_op_flash_attn'
3843 | ggml_sycl_op_flash_attn(ctx, dst);
| ^
/home/xxx/hd1/llama.cpp/llama.cpp_saf-ye_flash-attn/ggml/src/ggml-sycl/ggml-sycl.cpp:4508:20: error: use of undeclared identifier 'ggml_sycl_flash_attn_ext_supported'
4508 | return ggml_sycl_flash_attn_ext_supported(op);
| ^
/home/xxx/hd1/llama.cpp/llama.cpp_saf-ye_flash-attn/ggml/src/ggml-sycl/pad.cpp:64:30: warning: unused parameter 'item_ct1' [-Wunused-parameter]
64 | [=](sycl::nd_item<3> item_ct1) {
| ^
2 errors generated.
Co-authored-by: safranowith <[email protected]> Co-authored-by: ye-NX <[email protected]> Co-authored-by: Neo Zhang Jianyu <[email protected]>
Co-authored-by: Neo Zhang Jianyu <[email protected]> Co-authored-by: ye-NX <[email protected]> Co-authored-by: safranowith <[email protected]>
Co-authored-by: safranowith <[email protected]> Co-authored-by: ye-NX <[email protected]> Co-authored-by: Sigbjørn Skjæret <[email protected]>
693157c to
af5b644
Compare
Co-authored-by: safranowith <[email protected]> Co-authored-by: ye-NX <[email protected]>
Co-authored-by: safranowith <[email protected]> Co-authored-by: ye-NX <[email protected]>
fdf83f7 to
dcd7ca5
Compare
|
The building is passed.
|
|
Thanks for feedback! |
Ok! It's great! In fact, I'm implementing the flash attention too. It will support more data types. It need several weeks to be finished. Cancel my task and depend on your implementation? How do you think? |
What a coincidence... |
Yes! I will support you! I want to contact to you by email. But I can't see your email address. Thank you! |
This PR adds basic Flash Attention support for the SYCL backend, enabling more efficient attention computation on Intel GPUs.
Authors:
Joint work by @safranowith and @ye-NX
Notes: