Skip to content

Commit 4724644

Browse files
committed
ci : disable CUDA and Android builds
1 parent 11dddfb commit 4724644

File tree

2 files changed

+98
-94
lines changed

2 files changed

+98
-94
lines changed

.github/workflows/build.yml

Lines changed: 95 additions & 93 deletions
Original file line numberDiff line numberDiff line change
@@ -430,71 +430,72 @@ jobs:
430430
name: whisper-blas-bin-${{ matrix.arch }}
431431
path: build/bin/${{ matrix.build }}
432432

433-
windows-cublas:
434-
runs-on: windows-2019
435-
436-
strategy:
437-
matrix:
438-
build: [Release]
439-
arch: [x64]
440-
cublas: [ON]
441-
sdl2: [ON]
442-
cuda-toolkit: [12.2.0, 11.8.0]
443-
include:
444-
- arch: x64
445-
s2arc: x64
446-
- sdl2: ON
447-
s2ver: 2.28.5
448-
449-
steps:
450-
- name: Clone
451-
uses: actions/checkout@v4
452-
453-
- name: Add msbuild to PATH
454-
uses: microsoft/setup-msbuild@v2
455-
456-
- name: Install CUDA Toolkit
457-
id: cuda-toolkit
458-
uses: Jimver/[email protected]
459-
with:
460-
cuda: '${{ matrix.cuda-toolkit }}'
461-
462-
- name: Fetch SDL2 and set SDL2_DIR
463-
if: matrix.sdl2 == 'ON'
464-
run: |
465-
C:/msys64/usr/bin/wget.exe -qO sdl2.zip https://github.com/libsdl-org/SDL/releases/download/release-${{ matrix.s2ver }}/SDL2-devel-${{ matrix.s2ver }}-VC.zip
466-
7z x sdl2.zip
467-
echo "SDL2_DIR=$env:GITHUB_WORKSPACE/SDL2-${{ matrix.s2ver }}/cmake" >> $env:GITHUB_ENV
468-
469-
- name: Configure
470-
run: >
471-
cmake -S . -B ./build -A ${{ matrix.arch }}
472-
-DCMAKE_BUILD_TYPE=${{ matrix.build }}
473-
-DGGML_CUDA=${{ matrix.cublas }}
474-
-DWHISPER_SDL2=${{ matrix.sdl2 }}
475-
476-
- name: Build ${{ matrix.cuda-toolkit }}
477-
run: |
478-
cd ./build
479-
cmake --build . --config ${{ matrix.build }}
480-
481-
- name: Copy CUDA DLLs
482-
run: >
483-
Copy-Item -PassThru
484-
-Path "${{ steps.cuda-toolkit.outputs.CUDA_PATH }}/bin/*.dll"
485-
-Include cudart64_*,cublas64_*,cublasLt64_*
486-
-Destination build/bin/${{ matrix.build }}
487-
488-
- name: Copy SDL2.dll
489-
if: matrix.sdl2 == 'ON'
490-
run: copy "$env:SDL2_DIR/../lib/${{ matrix.s2arc }}/SDL2.dll" build/bin/${{ matrix.build }}
491-
492-
- name: Upload binaries
493-
if: matrix.sdl2 == 'ON'
494-
uses: actions/upload-artifact@v4
495-
with:
496-
name: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}
497-
path: build/bin/${{ matrix.build }}
433+
# TODO: fix and re-enable
434+
# windows-cublas:
435+
# runs-on: windows-2019
436+
#
437+
# strategy:
438+
# matrix:
439+
# build: [Release]
440+
# arch: [x64]
441+
# cublas: [ON]
442+
# sdl2: [ON]
443+
# cuda-toolkit: [12.2.0, 11.8.0]
444+
# include:
445+
# - arch: x64
446+
# s2arc: x64
447+
# - sdl2: ON
448+
# s2ver: 2.28.5
449+
#
450+
# steps:
451+
# - name: Clone
452+
# uses: actions/checkout@v4
453+
#
454+
# - name: Add msbuild to PATH
455+
# uses: microsoft/setup-msbuild@v2
456+
#
457+
# - name: Install CUDA Toolkit
458+
# id: cuda-toolkit
459+
# uses: Jimver/[email protected]
460+
# with:
461+
# cuda: '${{ matrix.cuda-toolkit }}'
462+
#
463+
# - name: Fetch SDL2 and set SDL2_DIR
464+
# if: matrix.sdl2 == 'ON'
465+
# run: |
466+
# C:/msys64/usr/bin/wget.exe -qO sdl2.zip https://github.com/libsdl-org/SDL/releases/download/release-${{ matrix.s2ver }}/SDL2-devel-${{ matrix.s2ver }}-VC.zip
467+
# 7z x sdl2.zip
468+
# echo "SDL2_DIR=$env:GITHUB_WORKSPACE/SDL2-${{ matrix.s2ver }}/cmake" >> $env:GITHUB_ENV
469+
#
470+
# - name: Configure
471+
# run: >
472+
# cmake -S . -B ./build -A ${{ matrix.arch }}
473+
# -DCMAKE_BUILD_TYPE=${{ matrix.build }}
474+
# -DGGML_CUDA=${{ matrix.cublas }}
475+
# -DWHISPER_SDL2=${{ matrix.sdl2 }}
476+
#
477+
# - name: Build ${{ matrix.cuda-toolkit }}
478+
# run: |
479+
# cd ./build
480+
# cmake --build . --config ${{ matrix.build }}
481+
#
482+
# - name: Copy CUDA DLLs
483+
# run: >
484+
# Copy-Item -PassThru
485+
# -Path "${{ steps.cuda-toolkit.outputs.CUDA_PATH }}/bin/*.dll"
486+
# -Include cudart64_*,cublas64_*,cublasLt64_*
487+
# -Destination build/bin/${{ matrix.build }}
488+
#
489+
# - name: Copy SDL2.dll
490+
# if: matrix.sdl2 == 'ON'
491+
# run: copy "$env:SDL2_DIR/../lib/${{ matrix.s2arc }}/SDL2.dll" build/bin/${{ matrix.build }}
492+
#
493+
# - name: Upload binaries
494+
# if: matrix.sdl2 == 'ON'
495+
# uses: actions/upload-artifact@v4
496+
# with:
497+
# name: whisper-cublas-${{ matrix.cuda-toolkit }}-bin-${{ matrix.arch }}
498+
# path: build/bin/${{ matrix.build }}
498499

499500
emscripten:
500501
runs-on: ubuntu-latest
@@ -563,34 +564,35 @@ jobs:
563564
- name: Build swiftui example
564565
run: xcodebuild -project examples/whisper.swiftui/whisper.swiftui.xcodeproj -scheme WhisperCppDemo -configuration ${{ matrix.build }} -sdk iphoneos CODE_SIGNING_REQUIRED=NO CODE_SIGN_IDENTITY= -destination 'generic/platform=iOS' build
565566

566-
android:
567-
runs-on: ubuntu-latest
568-
569-
steps:
570-
- name: Clone
571-
uses: actions/checkout@v4
572-
with:
573-
path: whisper
574-
575-
- name: Install Java
576-
uses: actions/setup-java@v4
577-
with:
578-
distribution: zulu
579-
java-version: 21
580-
581-
- name: Setup Android SDK
582-
uses: android-actions/setup-android@v3
583-
584-
- name: Build
585-
run: |
586-
cd whisper/examples/whisper.android
587-
./gradlew assembleRelease --no-daemon
588-
589-
- name: Build with external ggml
590-
run: |
591-
export PATH_TO_GGML=$PWD/ggml
592-
cd whisper/examples/whisper.android
593-
./gradlew assembleRelease --no-daemon
567+
# TODO: update android build and re-enable when it works
568+
# android:
569+
# runs-on: ubuntu-latest
570+
#
571+
# steps:
572+
# - name: Clone
573+
# uses: actions/checkout@v4
574+
# with:
575+
# path: whisper
576+
#
577+
# - name: Install Java
578+
# uses: actions/setup-java@v4
579+
# with:
580+
# distribution: zulu
581+
# java-version: 21
582+
#
583+
# - name: Setup Android SDK
584+
# uses: android-actions/setup-android@v3
585+
#
586+
# - name: Build
587+
# run: |
588+
# cd whisper/examples/whisper.android
589+
# ./gradlew assembleRelease --no-daemon
590+
#
591+
# - name: Build with external ggml
592+
# run: |
593+
# export PATH_TO_GGML=$PWD/ggml
594+
# cd whisper/examples/whisper.android
595+
# ./gradlew assembleRelease --no-daemon
594596

595597
# TODO: disable because of following fail: https://github.com/ggerganov/whisper.cpp/actions/runs/11019444420/job/30627193602
596598
# android_java:

examples/whisper.android/lib/src/main/jni/whisper/CMakeLists.txt

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,16 @@ set(CMAKE_CXX_STANDARD 17)
66
set(WHISPER_LIB_DIR ${CMAKE_SOURCE_DIR}/../../../../../../..)
77

88
# Path to external GGML, otherwise uses the copy in whisper.cpp.
9-
option(GGML_HOME "whisper: Path to external GGML source" OFF)
9+
option(GGML_HOME "whisper: Path to external GGML source" OFF)
1010

1111
set(
1212
SOURCE_FILES
1313
${WHISPER_LIB_DIR}/src/whisper.cpp
1414
${CMAKE_SOURCE_DIR}/jni.c
1515
)
1616

17+
# TODO: this needs to be updated to work with the new ggml CMakeLists
18+
1719
if (NOT GGML_HOME)
1820
set(
1921
SOURCE_FILES

0 commit comments

Comments
 (0)