Skip to content

Commit 9dd9685

Browse files
ruby : test extra build options only when env var specified (#3136)
* Test Ruby bindings' extra options only when commanded * ruby : test extra build options only when env var specified * Fix extra_options * Update gem date
1 parent 2e310b8 commit 9dd9685

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

bindings/ruby/ext/options.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def missing_options
5353
end
5454

5555
def extra_options
56-
@options.keys + @pending_options - @ignored_options -
56+
@options.keys + @pending_options + @ignored_options -
5757
cmake_options.collect {|name, type, value| name}
5858
end
5959

bindings/ruby/tests/test_package.rb

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -37,14 +37,9 @@ def assert_installed(dir, version)
3737
end
3838

3939
def test_build_options
40-
# This test is disabled as it currently fails when run locally on macOS and
41-
# Linux. We need to find a good way to handle the situation with build
42-
# options which varies between platforms.
43-
# Refs: https://github.com/ggml-org/whisper.cpp/pull/3132
44-
omit "Temporarily disabled locally as this test currently fails when run locally" unless ENV["CI"]
4540
options = BuildOptions::Options.new
4641
assert_empty options.missing_options
47-
unless ENV["CI"]
42+
if ENV["TEST_EXTRA_OPTIONS"] == "1"
4843
assert_empty options.extra_options
4944
end
5045
end

bindings/ruby/whispercpp.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Gem::Specification.new do |s|
44
s.name = "whispercpp"
55
s.authors = ["Georgi Gerganov", "Todd A. Fisher"]
66
s.version = '1.3.2'
7-
s.date = '2025-05-01'
7+
s.date = '2025-05-11'
88
s.description = %q{High-performance inference of OpenAI's Whisper automatic speech recognition (ASR) model via Ruby}
99
s.email = '[email protected]'
1010
s.extra_rdoc_files = ['LICENSE', 'README.md']

0 commit comments

Comments
 (0)