Where is WHISPER_VERSION defined?

[marcobambini]

I am trying to use the Whisper source code, but after upgrading to the latest 1.7.6, the WHISPER_VERSION definition is not found (used in const char * whisper_version(void) in whisper.cpp).

Any help?

[misutoneko]

The version is defined in CMakeLists.txt, so I guess cmake is a hard requirement unless you define it yourself somehow.

[marcobambini]

I used cmake to build whisper.cpp and I thought that the WHISPER_VERSION definition would be added to whisper.h.
If not, I think it should be treated as a bug.

[misutoneko]

Well, I'm not a cmake expert by any strech of imagination, but maybe something like this?

whisper.cpp_generate_version_h_patch.diff.gz

The rule will generate a new file version.h at the top level directory.

[danbev]

I used cmake to build whisper.cpp and I thought that the WHISPER_VERSION definition would be added to whisper.h. If not, I think it should be treated as a bug.

Could you help me understand what advantage you see in having the version in whisper.h?

I introduced this is #3289 and thought this was cleaner than alternatives like having to generated whisper.h, or a separate version.h header. I was mainly concerned about build time complexity and not adding additional files.

I'm definitely open to reconsidering this if there are concrete benefits I'm missing, what use case were you thinking of?

[marcobambini]

@danbev thanks for the reply.
To better understand Whisper’s internals, I usually link to whisper.cpp from within Xcode (instead of using the compiled library). However, with the new build process, this is basically impossible.

[danbev]

To better understand Whisper’s internals, I usually link to whisper.cpp from within Xcode (instead of using the compiled library)

Ah I see, that is something that I had not considered. I'll try to take a closer look at how this works with Xcode. Thanks