From 00797403bd43ebcb1e0678989a4fc676d417b4af Mon Sep 17 00:00:00 2001 From: Gilbert Gong Date: Wed, 25 Sep 2024 16:11:51 -0700 Subject: [PATCH 1/3] Remove possible leftover ffmpeg temp file from a previous failed conversion --- examples/server/server.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/examples/server/server.cpp b/examples/server/server.cpp index 60b96d497e6..cfbed21cbb8 100644 --- a/examples/server/server.cpp +++ b/examples/server/server.cpp @@ -219,6 +219,8 @@ void check_ffmpeg_availibility() { bool convert_to_wav(const std::string & temp_filename, std::string & error_resp) { std::ostringstream cmd_stream; std::string converted_filename_temp = temp_filename + "_temp.wav"; + // Remove possible leftover ffmpeg temp file from a previous failed conversion + remove(converted_filename_temp.c_str()); cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1"; std::string cmd = cmd_stream.str(); From f38b2286290287c05e61442be3e5407c4c98e1da Mon Sep 17 00:00:00 2001 From: Gilbert Gong Date: Thu, 26 Sep 2024 11:00:39 -0700 Subject: [PATCH 2/3] Revert "Remove possible leftover ffmpeg temp file from a previous failed conversion" This reverts commit 00797403bd43ebcb1e0678989a4fc676d417b4af. --- examples/server/server.cpp | 2 -- 1 file changed, 2 deletions(-) diff --git a/examples/server/server.cpp b/examples/server/server.cpp index cfbed21cbb8..60b96d497e6 100644 --- a/examples/server/server.cpp +++ b/examples/server/server.cpp @@ -219,8 +219,6 @@ void check_ffmpeg_availibility() { bool convert_to_wav(const std::string & temp_filename, std::string & error_resp) { std::ostringstream cmd_stream; std::string converted_filename_temp = temp_filename + "_temp.wav"; - // Remove possible leftover ffmpeg temp file from a previous failed conversion - remove(converted_filename_temp.c_str()); cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1"; std::string cmd = cmd_stream.str(); From 3f469b2278d95b9c09f2d7ac020c180e3c774d62 Mon Sep 17 00:00:00 2001 From: Gilbert Gong Date: Thu, 26 Sep 2024 11:02:36 -0700 Subject: [PATCH 3/3] Flag to force ffmpeg to overwrite output file if it exists --- examples/server/server.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/server/server.cpp b/examples/server/server.cpp index 60b96d497e6..e7d7c8ae2b5 100644 --- a/examples/server/server.cpp +++ b/examples/server/server.cpp @@ -219,7 +219,7 @@ void check_ffmpeg_availibility() { bool convert_to_wav(const std::string & temp_filename, std::string & error_resp) { std::ostringstream cmd_stream; std::string converted_filename_temp = temp_filename + "_temp.wav"; - cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1"; + cmd_stream << "ffmpeg -i \"" << temp_filename << "\" -y -ar 16000 -ac 1 -c:a pcm_s16le \"" << converted_filename_temp << "\" 2>&1"; std::string cmd = cmd_stream.str(); int status = std::system(cmd.c_str());