[BUGFIX] sycl: Fix macro collision with standard math functions #3298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not keen to merge this workaround until we spend a bit of time to understand whether there is a better solution. I believe I've seen a similar workaround before, I just can't find what was done about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
I found a fix for the compile time bugs/errors I've been getting here:
#3297
I'm by no means a C++ expert & I'm sure there is a more elegant way to fix this.
This fixed the compilation for me, now I can run whisper models with SYCL hardware acceleration on my
Intel Ultra Series 2 laptop Omnibook Ultra Flip 14" running on NixOS(with a very hacky & advanced flake.nix) !!!
CPU: Intel Ultra 7 258V (8) @ 4.800GHz
GPU: Intel Arc Graphics 130V / 140V