Merge pull request hpcc-systems#19552 from streeterd/HPCC-33482_Remove_unnecessary_and_inefficient_double_lock_in_CDistributedFile

HPCC-33482 Remove unnecessary and inefficient double lock in CDistributedFile

Reviewed-by: Jake Smith <jake.smith@lexisnexisrisk.com>
Reviewed-by: Gavin Halliday <ghalliday@hpccsystems.com>
Merged-by: Gavin Halliday <ghalliday@hpccsystems.com>

Author: ghalliday

dali/base/dadfs.cpp

@@ -3488,7 +3488,6 @@ class CDistributedFile: public CDistributedFileBase<IDistributedFile>
             for (i1=0;i1<n;i1++) {
                 if (parts.item(i1).clearDirty()||force) {
                     MemoryBuffer mb;
-                    CriticalBlock block (sect);
                     ForEachItemIn(i2,parts)
                         serializePartAttr(mb,parts.item(i2).queryAttr());
                     root->setPropBin("Parts",mb.length(),mb.toByteArray());