Merge pull request #30 from TheSuperiorStanislav/fix-nested-read-only-fields

Ignore nested read-only fields

Author: ghazi-git

drf_standardized_errors/openapi_utils.py

@@ -44,7 +44,7 @@ def get_flat_serializer_fields(
     for composite fields by returning 2 fields: one for the errors linked to
     the parent field and another one for errors linked to the child field.
     """
-    if not field:
+    if not field or getattr(field, "read_only", False):
         return []
 
     field = force_instance(field)

tests/test_openapi_utils.py

@@ -38,6 +38,13 @@ class CustomSerializer(serializers.Serializer):
     field4 = NestedSerializer(many=True)
 
 
+class CustomSerializerWithNestedReadOnly(serializers.Serializer):
+    field1 = serializers.CharField()
+    field2 = serializers.ListField(child=serializers.IntegerField())
+    field3 = NestedSerializer(read_only=True)
+    field4 = NestedSerializer(read_only=True, many=True)
+
+
 def test_get_flat_serializer_fields():
     fields = get_flat_serializer_fields(CustomSerializer(many=True))
     expected_fields = {
@@ -59,6 +66,19 @@ def test_get_flat_serializer_fields():
     assert {field.name for field in fields} == expected_fields
 
 
+def test_get_flat_serializer_fields_with_nested_read_only():
+    """Check case when NestedSerializer is read-only with non read-only fields."""
+    fields = get_flat_serializer_fields(CustomSerializerWithNestedReadOnly(many=True))
+    expected_fields = {
+        "non_field_errors",
+        "INDEX.non_field_errors",
+        "INDEX.field1",
+        "INDEX.field2",
+        "INDEX.field2.INDEX",
+    }
+    assert {field.name for field in fields} == expected_fields
+
+
 @pytest.fixture
 def char_field():
     return InputDataField(