Skip to content

Commit 4dc19dc

Browse files
committed
don't hardcode function names in code evaluated by chrome.devtools.inspectedWindow.eval to account for code minification during the build process
1 parent f05d0ae commit 4dc19dc

File tree

6 files changed

+10
-5
lines changed

6 files changed

+10
-5
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,11 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/).
55

66
## [Unreleased]
77

8+
### Fixed
9+
10+
- Avoid hardcoding function names in code evaluated by `chrome.devtools.inspectedWindow.eval` to account for code
11+
minification during the build process.
12+
813
## [1.0.0] - 2025-11-27
914

1015
### Added

src/devtools/utils/inspected-window-data-create.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ function getDataCreationCode(request: DataCreationRequest) {
2727
const serializedRequest = JSON.stringify(request);
2828
return `
2929
(function() {
30-
processDataCreationRequest(${serializedRequest})
30+
${processDataCreationRequest.name}(${serializedRequest})
3131
3232
${processDataCreationRequest.toString()}
3333
${insertObjects.toString()}

src/devtools/utils/inspected-window-data-delete.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function getDataDeletionCode(request: DataDeletionRequest) {
2828
const serializedRequest = JSON.stringify(request);
2929
return `
3030
(function() {
31-
processDataDeletionRequest(${serializedRequest})
31+
${processDataDeletionRequest.name}(${serializedRequest})
3232
3333
${processDataDeletionRequest.toString()}
3434
${deleteObjects.toString()}

src/devtools/utils/inspected-window-data-fetch.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ function getDataRequestCode(
5050

5151
return `
5252
(function() {
53-
processDataRequest(${serializedRequestID}, ${serializedDBName}, ${serializedStoreName}, ${serializedColumns}, ${serializedCount})
53+
${processDataRequest.name}(${serializedRequestID}, ${serializedDBName}, ${serializedStoreName}, ${serializedColumns}, ${serializedCount})
5454
5555
${processDataRequest.toString()}
5656
${getObjectStoreData.toString()}

src/devtools/utils/inspected-window-data-update.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function getDataUpdateCode(request: DataUpdateRequest) {
2828
const serializedRequest = JSON.stringify(request);
2929
return `
3030
(function() {
31-
processDataUpdateRequest(${serializedRequest})
31+
${processDataUpdateRequest.name}(${serializedRequest})
3232
3333
${processDataUpdateRequest.toString()}
3434
${updateObjectField.toString()}

src/devtools/utils/inspected-window-databases.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ function getDatabasesRequestCode(requestID: string) {
2323
const serializedErrorMsg = JSON.stringify(DATABASES_ERROR_MSG);
2424
return `
2525
(function() {
26-
processDatabasesRequest(${serializedRequestID}, ${serializedErrorMsg})
26+
${processDatabasesRequest.name}(${serializedRequestID}, ${serializedErrorMsg})
2727
2828
${processDatabasesRequest.toString()}
2929
${markRequestInProgress.toString()}

0 commit comments

Comments
 (0)