Cleanup httpResource usage and apply security update (#254)

Author: Cito

.devcontainer/dev_install

@@ -4,7 +4,7 @@
 cd /workspace
 
 echo "Install pnpm..."
-corepack prepare pnpm@10.25.0 --activate
+corepack prepare pnpm@10.26.0 --activate
 
 echo "Add Markdown TOC generator for updating the Readme"
 npm install -g markdown-toc-gen

Dockerfile

@@ -6,7 +6,7 @@ RUN apk upgrade --no-cache --available
 FROM base AS builder
 # install pnpm
 RUN npm install --global corepack@0.32.0
-RUN corepack prepare pnpm@10.25.0 --activate
+RUN corepack prepare pnpm@10.26.0 --activate
 # install static web server
 RUN apk add curl jq sudo which
 RUN curl --proto '=https' --tlsv1.2 -sSfL https://get.static-web-server.net | sed "s/cp -ax/cp -a/g" | sh

package.json

@@ -1,6 +1,6 @@
 {
   "name": "data-portal",
-  "version": "2.3.0",
+  "version": "2.3.1",
   "scripts": {
     "ng": "ng",
     "start": "ng serve",
@@ -23,9 +23,14 @@
     "compodoc:serve": "compodoc -s",
     "toc": "markdown-toc-gen update README.md"
   },
-  "packageManager": "pnpm@10.25.0",
+  "packageManager": "pnpm@10.26.0",
   "type": "module",
   "private": true,
+  "pnpm": {
+    "overrides": {
+      "glob": "^13.0.0"
+    }
+  },
   "dependencies": {
     "@angular/animations": "^21.0.5",
     "@angular/cdk": "^21.0.3",
@@ -82,7 +87,7 @@
     "tailwindcss": "^4.1.18",
     "ts-node": "^10.9.2",
     "typescript": "~5.9.3",
-    "typescript-eslint": "^8.49.0",
+    "typescript-eslint": "^8.50.0",
     "vitest": "^4.0.15"
   },
   "msw": {

pnpm-lock.yaml

@@ -292,7 +292,7 @@ <h1>Access Request Details</h1>
         </div>
       }
     </div>
-  } @else if (loading()) {
+  } @else if (isLoading()) {
     <p>Loading request details...</p>
   } @else {
     <div class="container mx-auto p-6">

src/app/access-requests/features/access-request-manager-detail/access-request-manager-detail.html

@@ -101,7 +101,7 @@ export class AccessRequestManagerDetailComponent implements OnInit, HasPendingEd
       (this.#request.error() ? undefined : this.#request.value()),
   );
 
-  loading = computed<boolean>(
+  isLoading = computed<boolean>(
     () => !this.#cachedRequest() && this.#request.isLoading(),
   );
 

src/app/access-requests/features/access-request-manager-detail/access-request-manager-detail.ts

@@ -250,7 +250,7 @@ <h2 class="mb-4 font-semibold">Account Details</h2>
         }
       </mat-card-content>
     </mat-card>
-  } @else if (loading()) {
+  } @else if (isLoading()) {
     <p>Loading user details...</p>
   } @else {
     <div class="container mx-auto p-6">

src/app/auth/features/user-manager-detail/user-manager-detail.html

@@ -86,7 +86,7 @@ export class UserManagerDetailComponent implements OnInit {
     () => this.#cachedUser() || (this.#user.error() ? undefined : this.#user.value()),
   );
 
-  loading = computed<boolean>(() => !this.#cachedUser() && this.#user.isLoading());
+  isLoading = computed<boolean>(() => !this.#cachedUser() && this.#user.isLoading());
 
   error = computed<undefined | 'not found' | 'other'>(() => {
     if (this.#cachedUser()) return undefined;

src/app/auth/features/user-manager-detail/user-manager-detail.ts

@@ -19,13 +19,9 @@ import { MetadataBrowserFilterComponent } from './metadata-browser-filter';
  * Mock the metadata service as needed for the metadata browser filter
  */
 class MockMetadataSearchService {
-  searchResultsResource = {
-    value: () => searchResults,
-    isLoading: () => false,
-    error: () => undefined,
-  };
   searchResults = () => searchResults;
   isLoading = () => false;
+  error = () => undefined;
   searchResultsLimit = () => 10;
   searchResultsSkip = () => 0;
   paginated = () => false;

src/app/metadata/features/metadata-browser-filter/metadata-browser-filter.spec.ts

@@ -59,12 +59,12 @@ export class MetadataBrowserFilterComponent implements OnInit {
   #route = inject(ActivatedRoute);
   #router = inject(Router);
   #metadataSearch = inject(MetadataSearchService);
-  #searchResults = this.#metadataSearch.searchResultsResource;
-  #facetResults = computed(() =>
-    this.#searchResults.error() ? [] : this.#searchResults.value().facets,
-  );
+
+  protected searchResults = this.#metadataSearch.searchResults;
+  protected isLoading = this.#metadataSearch.isLoading;
+  #error = this.#metadataSearch.error;
+  #facetResults = computed(() => this.searchResults()?.facets || []);
   protected facets = signal<Facet[]>([]);
-  readonly isLoading = computed(() => this.#metadataSearch.isLoading);
   pageSize = computed(() => this.#metadataSearch.searchResultsLimit());
   #skip = computed(() => this.#metadataSearch.searchResultsSkip());
   #currentFacet: string | null | undefined;
@@ -111,7 +111,7 @@ export class MetadataBrowserFilterComponent implements OnInit {
   });
 
   #deferredFacetUpdateEffect = effect(() => {
-    if (!this.#searchResults.error() && !this.#searchResults.isLoading()) {
+    if (!this.#error() && !this.isLoading()) {
       this.#updateFacetDeferred();
     }
   });