Skip to content

Commit ebdc39a

Browse files
authored
Overhaul download token creation (#266)
1 parent e4c61b1 commit ebdc39a

File tree

23 files changed

+1809
-1429
lines changed

23 files changed

+1809
-1429
lines changed

.github/copilot-instructions.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,15 @@ This repo uses `pnpm` (not npm) for dependency installation and scripts.
3030
- Prefer type inference when the type is obvious
3131
- Avoid the `any` type; use `unknown` when type is uncertain
3232

33+
## Documentation
34+
35+
- All functions, methods, and classes require JSDoc comments (enforced via eslint-plugin-jsdoc)
36+
- JSDoc must include `@param` for all parameters and `@returns` for non-void return types
37+
- JSDoc must include a description line for the function/method/class
38+
- Keep JSDoc comments concise and meaningful - avoid redundancy with code that is self-explanatory
39+
- Empty constructors are exempt from JSDoc requirements
40+
- Arrow function expressions do not require JSDoc by linting rules, but should still include JSDoc when the function is not self-explanatory and needs deeper explanation
41+
3342
## Angular Best Practices
3443

3544
- Always use standalone components over NgModules

eslint.config.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,10 @@ export default [
127127
['pipe', { context: 'ivas' }],
128128
],
129129
},
130+
{
131+
from: [['model', { context: 'access-requests' }]],
132+
allow: [['model', { context: 'ivas' }]],
133+
},
130134
// auth context may import from verification addresses context
131135
{
132136
from: [['features', { context: 'auth' }]],
@@ -242,6 +246,7 @@ export default [
242246
from: ['features', 'service', 'model', 'mock'],
243247
allow: [['model', { context: 'auth' }]],
244248
},
249+
245250
// Mock module may only import models
246251
{
247252
from: ['mock'],

package.json

Lines changed: 26 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "data-portal",
3-
"version": "2.3.3",
3+
"version": "2.4.0",
44
"scripts": {
55
"ng": "ng",
66
"start": "ng serve",
@@ -31,17 +31,17 @@
3131
"type": "module",
3232
"private": true,
3333
"dependencies": {
34-
"@angular/animations": "^21.1.1",
35-
"@angular/cdk": "^21.1.1",
36-
"@angular/common": "^21.1.1",
37-
"@angular/compiler": "^21.1.1",
38-
"@angular/core": "^21.1.1",
39-
"@angular/forms": "^21.1.1",
40-
"@angular/material": "^21.1.1",
41-
"@angular/material-date-fns-adapter": "^21.1.1",
42-
"@angular/platform-browser": "^21.1.1",
43-
"@angular/platform-browser-dynamic": "^21.1.1",
44-
"@angular/router": "^21.1.1",
34+
"@angular/animations": "^21.1.3",
35+
"@angular/cdk": "^21.1.3",
36+
"@angular/common": "^21.1.3",
37+
"@angular/compiler": "^21.1.3",
38+
"@angular/core": "^21.1.3",
39+
"@angular/forms": "^21.1.3",
40+
"@angular/material": "^21.1.3",
41+
"@angular/material-date-fns-adapter": "^21.1.3",
42+
"@angular/platform-browser": "^21.1.3",
43+
"@angular/platform-browser-dynamic": "^21.1.3",
44+
"@angular/router": "^21.1.3",
4545
"@ngneat/cashew": "^5.3.0",
4646
"@tailwindcss/postcss": "^4.1.18",
4747
"angularx-qrcode": "^21.0.4",
@@ -53,34 +53,34 @@
5353
"tslib": "^2.8.1"
5454
},
5555
"devDependencies": {
56-
"@angular-eslint/eslint-plugin": "^21.1.0",
57-
"@angular-eslint/eslint-plugin-template": "^21.1.0",
58-
"@angular-eslint/template-parser": "^21.1.0",
59-
"@angular/build": "^21.1.1",
60-
"@angular/cli": "^21.1.1",
61-
"@angular/compiler-cli": "^21.1.1",
56+
"@angular-eslint/eslint-plugin": "^21.2.0",
57+
"@angular-eslint/eslint-plugin-template": "^21.2.0",
58+
"@angular-eslint/template-parser": "^21.2.0",
59+
"@angular/build": "^21.1.2",
60+
"@angular/cli": "^21.1.2",
61+
"@angular/compiler-cli": "^21.1.3",
6262
"@compodoc/compodoc": "^1.2.1",
6363
"@eslint/js": "^9.39.2",
6464
"@eslint/markdown": "^7.5.1",
65-
"@playwright/test": "^1.58.0",
65+
"@playwright/test": "^1.58.1",
6666
"@testing-library/angular": "^19.0.0",
6767
"@testing-library/jest-dom": "^6.9.1",
6868
"@testing-library/user-event": "^14.6.1",
69-
"@types/node": "^25.0.10",
69+
"@types/node": "^25.2.0",
7070
"@vitest/browser-playwright": "^4.0.18",
7171
"@vitest/ui": "4.0.18",
72-
"angular-eslint": "^21.1.0",
73-
"autoprefixer": "^10.4.23",
72+
"angular-eslint": "^21.2.0",
73+
"autoprefixer": "^10.4.24",
7474
"eslint": "^9.39.2",
7575
"eslint-config-prettier": "^10.1.8",
7676
"eslint-import-resolver-typescript": "^4.4.4",
77-
"eslint-plugin-boundaries": "^5.3.1",
77+
"eslint-plugin-boundaries": "^5.4.0",
7878
"eslint-plugin-header": "^3.1.1",
79-
"eslint-plugin-jsdoc": "^62.4.1",
79+
"eslint-plugin-jsdoc": "^62.5.1",
8080
"eslint-plugin-prettier": "^5.5.5",
8181
"husky": "^9.1.7",
82-
"jsdom": "^27.4.0",
83-
"msw": "^2.12.7",
82+
"jsdom": "^28.0.0",
83+
"msw": "^2.12.8",
8484
"postcss": "^8.5.6",
8585
"prettier": "^3.8.1",
8686
"prettier-plugin-tailwindcss": "^0.7.2",

0 commit comments

Comments
 (0)