Skip to content
This repository was archived by the owner on Jun 1, 2025. It is now read-only.

Commit 07d94d7

Browse files
Ghislain BeaulacGhislain Beaulac
authored andcommitted
fix again highlight row throwing slickgrid error with updateItem
1 parent 8d5171c commit 07d94d7

File tree

11 files changed

+33
-16
lines changed

11 files changed

+33
-16
lines changed

dist/angular-slickgrid.es5.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10951,7 +10951,10 @@ var GridExtraService = /** @class */ (function () {
1095110951
setTimeout(function () {
1095210952
if (item && item.id) {
1095310953
delete item.rowClass;
10954-
_this._dataView.updateItem(item.id, item);
10954+
var /** @type {?} */ gridIdx = _this._dataView.getIdxById(item.id);
10955+
if (gridIdx !== undefined) {
10956+
_this._dataView.updateItem(item.id, item);
10957+
}
1095510958
}
1095610959
}, fadeDelay + 10);
1095710960
}
@@ -11017,7 +11020,8 @@ var GridExtraService = /** @class */ (function () {
1101711020
if (itemId === -1) {
1101811021
throw new Error("Could not find the item in the item in the grid or it's associated \"id\"");
1101911022
}
11020-
if (item && itemId >= 0) {
11023+
var /** @type {?} */ gridIdx = this._dataView.getIdxById(itemId);
11024+
if (gridIdx !== undefined) {
1102111025
// Update the item itself inside the dataView
1102211026
this._dataView.updateItem(itemId, item);
1102311027
// highlight the row we just updated

dist/angular-slickgrid.es5.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/angular-slickgrid.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12704,7 +12704,10 @@ class GridExtraService {
1270412704
setTimeout(() => {
1270512705
if (item && item.id) {
1270612706
delete item.rowClass;
12707-
this._dataView.updateItem(item.id, item);
12707+
const /** @type {?} */ gridIdx = this._dataView.getIdxById(item.id);
12708+
if (gridIdx !== undefined) {
12709+
this._dataView.updateItem(item.id, item);
12710+
}
1270812711
}
1270912712
}, fadeDelay + 10);
1271012713
}
@@ -12770,7 +12773,8 @@ class GridExtraService {
1277012773
if (itemId === -1) {
1277112774
throw new Error(`Could not find the item in the item in the grid or it's associated "id"`);
1277212775
}
12773-
if (item && itemId >= 0) {
12776+
const /** @type {?} */ gridIdx = this._dataView.getIdxById(itemId);
12777+
if (gridIdx !== undefined) {
1277412778
// Update the item itself inside the dataView
1277512779
this._dataView.updateItem(itemId, item);
1277612780
// highlight the row we just updated

dist/angular-slickgrid.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/bundles/angular-slickgrid.umd.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10950,7 +10950,10 @@ var GridExtraService = /** @class */ (function () {
1095010950
setTimeout(function () {
1095110951
if (item && item.id) {
1095210952
delete item.rowClass;
10953-
_this._dataView.updateItem(item.id, item);
10953+
var /** @type {?} */ gridIdx = _this._dataView.getIdxById(item.id);
10954+
if (gridIdx !== undefined) {
10955+
_this._dataView.updateItem(item.id, item);
10956+
}
1095410957
}
1095510958
}, fadeDelay + 10);
1095610959
}
@@ -11016,7 +11019,8 @@ var GridExtraService = /** @class */ (function () {
1101611019
if (itemId === -1) {
1101711020
throw new Error("Could not find the item in the item in the grid or it's associated \"id\"");
1101811021
}
11019-
if (item && itemId >= 0) {
11022+
var /** @type {?} */ gridIdx = this._dataView.getIdxById(itemId);
11023+
if (gridIdx !== undefined) {
1102011024
// Update the item itself inside the dataView
1102111025
this._dataView.updateItem(itemId, item);
1102211026
// highlight the row we just updated

dist/bundles/angular-slickgrid.umd.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/bundles/angular-slickgrid.umd.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/bundles/angular-slickgrid.umd.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

dist/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
{"name":"angular-slickgrid","version":"0.7.8","description":"Slickgrid components made available in Angular","keywords":["angular","plugin","datatable","slickgrid"],"license":"MIT","scripts":{"ng":"ng","start":"ng serve","build":"ng build","test":"ng test","lint":"ng lint","e2e":"ng e2e","build-lib":"npm-run-all packagr sass:build sass:copy copy:i18n","build-lib-pack":"npm-run-all build-lib pack-lib copy-pack del-pack","copy:i18n":"cross-env copyfiles -f src/assets/i18n/*.json dist/i18n","copy-pack":"cross-env copyfiles -f *.tgz ../Angular-Slickgrid-PackageTest","del-pack":"cross-env del *.tgz","pack-lib":"npm pack ./dist","packagr":"ng-packagr -p ng-package.json","sass-build-task:scss-compile":"node-sass --source-map true src/app/modules/angular-slickgrid/styles/ -o dist/styles/css","sass-build-task:autoprefixer":"postcss dist/styles/css/*.css --use autoprefixer -d dist/styles/css","sass:build":"npm-run-all -p sass-build-task:*","sass:copy":"cross-env copyfiles -f src/app/modules/angular-slickgrid/styles/*.scss dist/styles/sass","sass:watch":"node-sass 'src/app/modules/angular-slickgrid/styles/**/*.scss' -c 'npm run sass:build'"},"author":"Ghislain B.","repository":{"type":"git","url":"http://github.com/ghiscoding/angular-slickgrid"},"private":false,"dependencies":{"@ngx-translate/core":"^9.0.1","@ngx-translate/http-loader":"^2.0.0","bootstrap":"^3.3.7","core-js":"^2.5.1","flatpickr":"^4.0.6","font-awesome":"^4.7.0","jquery":"^3.2.1","lodash":"^4.17.4","moment-mini":"^2.18.1","slickgrid":"^2.3.12","vinyl-paths":"^2.1.0"},"devDependencies":{"@angular/animations":"^5.0.0","@angular/cli":"1.5.4","@angular/common":"^5.0.0","@angular/compiler":"^5.0.0","@angular/compiler-cli":"^5.0.0","@angular/core":"^5.0.0","@angular/forms":"^5.0.0","@angular/http":"^5.0.0","@angular/language-service":"^5.0.0","@angular/platform-browser":"^5.0.0","@angular/platform-browser-dynamic":"^5.0.0","@angular/router":"^5.0.0","@types/flatpickr":"^3.1.2","@types/jasmine":"~2.6.0","@types/jasminewd2":"~2.0.3","@types/moment":"^2.13.0","@types/node":"^8.0.39","codelyzer":"~3.2.0","copyfiles":"^1.2.0","cross-env":"^5.1.0","del":"^3.0.0","del-cli":"^1.1.0","gulp":"^3.9.1","gulp-bump":"^2.7.0","gulp-sass":"^3.1.0","gulp-yuidoc":"^0.1.2","jasmine-core":"~2.8.0","jasmine-spec-reporter":"~4.2.1","karma":"~1.7.1","karma-chrome-launcher":"~2.2.0","karma-cli":"~1.0.1","karma-coverage-istanbul-reporter":"^1.3.0","karma-jasmine":"~1.1.0","karma-jasmine-html-reporter":"^0.2.2","ng-packagr":"^1.6.0","node-sass":"^4.5.3","npm-run-all":"^4.1.1","postcss-cli":"^4.1.1","protractor":"~5.1.2","require-dir":"^0.3.2","run-sequence":"^2.2.0","rxjs":"^5.4.2","ts-node":"~3.3.0","tslint":"^5.8.0","typescript":"^2.3.4","yargs":"^9.0.1","zone.js":"^0.8.17"},"main":"bundles/angular-slickgrid.umd.js","module":"angular-slickgrid.es5.js","es2015":"angular-slickgrid.js","typings":"angular-slickgrid.d.ts","metadata":"angular-slickgrid.metadata.json"}
1+
{"name":"angular-slickgrid","version":"0.7.9","description":"Slickgrid components made available in Angular","keywords":["angular","plugin","datatable","slickgrid"],"license":"MIT","scripts":{"ng":"ng","start":"ng serve","build":"ng build","test":"ng test","lint":"ng lint","e2e":"ng e2e","build-lib":"npm-run-all packagr sass:build sass:copy copy:i18n","build-lib-pack":"npm-run-all build-lib pack-lib copy-pack del-pack","copy:i18n":"cross-env copyfiles -f src/assets/i18n/*.json dist/i18n","copy-pack":"cross-env copyfiles -f *.tgz ../Angular-Slickgrid-PackageTest","del-pack":"cross-env del *.tgz","pack-lib":"npm pack ./dist","packagr":"ng-packagr -p ng-package.json","sass-build-task:scss-compile":"node-sass --source-map true src/app/modules/angular-slickgrid/styles/ -o dist/styles/css","sass-build-task:autoprefixer":"postcss dist/styles/css/*.css --use autoprefixer -d dist/styles/css","sass:build":"npm-run-all -p sass-build-task:*","sass:copy":"cross-env copyfiles -f src/app/modules/angular-slickgrid/styles/*.scss dist/styles/sass","sass:watch":"node-sass 'src/app/modules/angular-slickgrid/styles/**/*.scss' -c 'npm run sass:build'"},"author":"Ghislain B.","repository":{"type":"git","url":"http://github.com/ghiscoding/angular-slickgrid"},"private":false,"dependencies":{"@ngx-translate/core":"^9.0.1","@ngx-translate/http-loader":"^2.0.0","bootstrap":"^3.3.7","core-js":"^2.5.1","flatpickr":"^4.0.6","font-awesome":"^4.7.0","jquery":"^3.2.1","lodash":"^4.17.4","moment-mini":"^2.18.1","slickgrid":"^2.3.12","vinyl-paths":"^2.1.0"},"devDependencies":{"@angular/animations":"^5.0.0","@angular/cli":"1.5.4","@angular/common":"^5.0.0","@angular/compiler":"^5.0.0","@angular/compiler-cli":"^5.0.0","@angular/core":"^5.0.0","@angular/forms":"^5.0.0","@angular/http":"^5.0.0","@angular/language-service":"^5.0.0","@angular/platform-browser":"^5.0.0","@angular/platform-browser-dynamic":"^5.0.0","@angular/router":"^5.0.0","@types/flatpickr":"^3.1.2","@types/jasmine":"~2.6.0","@types/jasminewd2":"~2.0.3","@types/moment":"^2.13.0","@types/node":"^8.0.39","codelyzer":"~3.2.0","copyfiles":"^1.2.0","cross-env":"^5.1.0","del":"^3.0.0","del-cli":"^1.1.0","gulp":"^3.9.1","gulp-bump":"^2.7.0","gulp-sass":"^3.1.0","gulp-yuidoc":"^0.1.2","jasmine-core":"~2.8.0","jasmine-spec-reporter":"~4.2.1","karma":"~1.7.1","karma-chrome-launcher":"~2.2.0","karma-cli":"~1.0.1","karma-coverage-istanbul-reporter":"^1.3.0","karma-jasmine":"~1.1.0","karma-jasmine-html-reporter":"^0.2.2","ng-packagr":"^1.6.0","node-sass":"^4.5.3","npm-run-all":"^4.1.1","postcss-cli":"^4.1.1","protractor":"~5.1.2","require-dir":"^0.3.2","run-sequence":"^2.2.0","rxjs":"^5.4.2","ts-node":"~3.3.0","tslint":"^5.8.0","typescript":"^2.3.4","yargs":"^9.0.1","zone.js":"^0.8.17"},"main":"bundles/angular-slickgrid.umd.js","module":"angular-slickgrid.es5.js","es2015":"angular-slickgrid.js","typings":"angular-slickgrid.d.ts","metadata":"angular-slickgrid.metadata.json"}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "angular-slickgrid",
3-
"version": "0.7.8",
3+
"version": "0.7.9",
44
"description": "Slickgrid components made available in Angular",
55
"keywords": [
66
"angular",

0 commit comments

Comments
 (0)