refactor(filter): simply use dot notation to detect complex object

Author: Ghislain Beaulac

src/app/examples/grid-clientside.component.ts

@@ -97,14 +97,18 @@ export class GridClientSideComponent implements OnInit {
       },
       { id: 'utcDate', name: 'UTC Date', field: 'utcDate', formatter: Formatters.dateTimeIsoAmPm, sortable: true, minWidth: 115,
         type: FieldType.dateUtc, outputType: FieldType.dateTimeIsoAmPm, filterable: true, filter: { model: Filters.compoundDate } },
-      { id: 'effort-driven', name: 'Effort Driven', field: 'effortDriven.isEffort', minWidth: 85, maxWidth: 85,
+      {
+        id: 'effort-driven', name: 'Effort Driven', field: 'effortDriven.isEffort', minWidth: 85, maxWidth: 85,
         type: FieldType.boolean,
         sortable: true,
-        filterable: true,
+
         // to pass multiple formatters, use the params property
         // also these formatters are executed in sequence, so if you want the checkmark to work correctly, it has to be the last formatter defined
         formatter: Formatters.multiple,
         params: { formatters: [Formatters.complexObject, Formatters.checkmark] },
+
+        // when the "field" string includes the dot "." notation, the library will consider this to be a complex object and Filter accordingly
+        filterable: true,
         filter: {
           // We can also add HTML text to be rendered (any bad script will be sanitized) but we have to opt-in, else it will be sanitized
           // enableRenderHtml: true,
@@ -115,7 +119,6 @@ export class GridClientSideComponent implements OnInit {
             value: 'isEffort',
             label: 'label'
           },
-          isComplexObject: true,
           model: Filters.singleSelect,
 
           // we could add certain option(s) to the "multiple-select" plugin

src/app/modules/angular-slickgrid/models/columnFilter.interface.ts

@@ -71,12 +71,6 @@ export interface ColumnFilter {
   /** Do we want the Filter to handle translation (localization)? */
   enableTranslateLabel?: boolean;
 
-  /**
-   * Defaults to false, does the filter has to deal with item that are complex object?
-   * If so, it will explode the object using the dot "." notation to find the value to filter against.
-   */
-  isComplexObject?: boolean;
-
   /**
    * Use "params" to pass any type of arguments to your Custom Filter
    * for example, to pass a second collection to a select Filter we can type this:

src/app/modules/angular-slickgrid/services/filter.service.ts

@@ -191,8 +191,8 @@ export class FilterService {
       const filterSearchType = (columnDef.filterSearchType) ? columnDef.filterSearchType : null;
       let cellValue = item[fieldName];
 
-      // when item is a complex object, we need to filter the value contained in the object following the dot "." notation
-      if (columnDef && columnDef.filter && columnDef.filter.isComplexObject) {
+      // when item is a complex object (dot "." notation), we need to filter the value contained in the object tree
+      if (fieldName.indexOf('.') >= 0) {
         cellValue = getDescendantProperty(item, fieldName);
       }