fix(formatters): some formatters were not considering empty string

Author: Ghislain Beaulac

src/app/modules/angular-slickgrid/formatters/boldFormatter.ts

@@ -2,7 +2,7 @@ import { Column, Formatter } from './../models/index';
 import { decimalFormatted } from './../services/utilities';
 
 export const boldFormatter: Formatter = (row: number, cell: number, value: any, columnDef: Column, dataContext: any) => {
-  const isNumber = (value === null || value === undefined) ? false : !isNaN(+value);
+  const isNumber = (value === null || value === undefined || value === '') ? false : !isNaN(+value);
   if (!isNumber) {
     return '';
   } else if (value >= 0) {

src/app/modules/angular-slickgrid/formatters/decimalFormatter.ts

@@ -5,7 +5,7 @@ export const decimalFormatter: Formatter = (row: number, cell: number, value: an
   const params = columnDef.params || {};
   const minDecimalPlaces = (params.minDecimalPlaces !== null && params.minDecimalPlaces) || (params.decimalPlaces !== null && params.decimalPlaces) || 2;
   const maxDecimalPlaces = (params.maxDecimalPlaces !== null && params.maxDecimalPlaces) || 2;
-  const isNumber = (value === null || value === undefined) ? false : !isNaN(+value);
+  const isNumber = (value === null || value === undefined || value === '') ? false : !isNaN(+value);
 
   return !isNumber ? value : `${decimalFormatted(value, minDecimalPlaces, maxDecimalPlaces)}`;
 };

src/app/modules/angular-slickgrid/formatters/dollarColoredBoldFormatter.ts

@@ -2,7 +2,7 @@ import { Column, Formatter } from './../models/index';
 import { decimalFormatted } from './../services/utilities';
 
 export const dollarColoredBoldFormatter: Formatter = (row: number, cell: number, value: any, columnDef: Column, dataContext: any) => {
-  const isNumber = (value === null || value === undefined) ? false : !isNaN(+value);
+  const isNumber = (value === null || value === undefined || value === '') ? false : !isNaN(+value);
   const params = columnDef && columnDef.params || {};
   const minDecimal = params.minDecimal || 2;
   const maxDecimal = params.minDecimal || 4;

src/app/modules/angular-slickgrid/formatters/dollarColoredFormatter.ts

@@ -2,7 +2,7 @@ import { Column, Formatter } from './../models/index';
 import { decimalFormatted } from './../services/utilities';
 
 export const dollarColoredFormatter: Formatter = (row: number, cell: number, value: any, columnDef: Column, dataContext: any) => {
-  const isNumber = (value === null || value === undefined) ? false : !isNaN(+value);
+  const isNumber = (value === null || value === undefined || value === '') ? false : !isNaN(+value);
   const params = columnDef && columnDef.params || {};
   const minDecimal = params.minDecimal || 2;
   const maxDecimal = params.minDecimal || 4;

src/app/modules/angular-slickgrid/formatters/dollarFormatter.ts

@@ -2,7 +2,7 @@ import { Column, Formatter } from './../models/index';
 import { decimalFormatted } from './../services/utilities';
 
 export const dollarFormatter: Formatter = (row: number, cell: number, value: any, columnDef: Column, dataContext: any) => {
-  const isNumber = (value === null || value === undefined) ? false : !isNaN(+value);
+  const isNumber = (value === null || value === undefined || value === '') ? false : !isNaN(+value);
   const params = columnDef && columnDef.params || {};
   const minDecimal = params.minDecimal || 2;
   const maxDecimal = params.minDecimal || 4;