fix(editors): regression bug causing infinite loop in rare occasion

- calling getEditorLock() into the save() method when editor cell value is invalid was sometime causing infinite loop and so getEditorLock() should only be called when value is valid
- also remove unused "commitEdit()" method, it wasn't called by anything

Author: Ghislain Beaulac

src/app/examples/custom-angularComponentEditor.ts

@@ -95,10 +95,13 @@ export class CustomAngularComponentEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/examples/custom-inputEditor.ts

@@ -98,10 +98,13 @@ export class CustomInputEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/examples/grid-editor.component.ts

@@ -178,25 +178,26 @@ export class GridEditorComponent implements OnInit {
         sortable: true,
         type: FieldType.number,
         filter: { model: Filters.slider, params: { hideSliderNumber: false } },
+        /*
         editor: {
           model: Editors.slider,
           minValue: 0,
           maxValue: 100,
           // params: { hideSliderNumber: true },
         },
-        /*
+        */
         editor: {
           // default is 0 decimals, if no decimals is passed it will accept 0 or more decimals
           // however if you pass the "decimalPlaces", it will validate with that maximum
           alwaysSaveOnEnterKey: true, // defaults to False, when set to true and user presses ENTER it will always call a Save even if value is empty
           model: Editors.float,
-          minValue: 0,
+          minValue: 5,
           maxValue: 365,
           // the default validation error message is in English but you can override it by using "errorMessage"
           // errorMessage: this.i18n.tr('INVALID_FLOAT', { maxDecimal: 2 }),
           params: { decimalPlaces: 2 },
         },
-        */
+
       }, {
         id: 'complete',
         name: '% Complete',

src/app/modules/angular-slickgrid/components/angular-slickgrid.component.ts

@@ -340,28 +340,6 @@ export class AngularSlickgridComponent implements AfterViewInit, OnDestroy, OnIn
     });
   }
 
-  /**
-   * Commits the current edit to the grid
-   */
-  commitEdit(target: Element) {
-    if (this.grid.getOptions().autoCommitEdit) {
-      const activeNode = this.grid.getActiveCellNode();
-
-      // a timeout must be set or this could come into conflict when slickgrid
-      // tries to commit the edit when going from one editor to another on the grid
-      // through the click event. If the timeout was not here it would
-      // try to commit/destroy the editor twice, which would throw a jquery
-      // error about the element not being in the DOM
-      setTimeout(() => {
-        // make sure the target is the active editor so we do not
-        // commit prematurely
-        if (activeNode && activeNode.contains(target) && this.grid.getEditorLock().isActive()) {
-          this.grid.getEditorLock().commitCurrentEdit();
-        }
-      });
-    }
-  }
-
   /**
    * Define our internal Post Process callback, it will execute internally after we get back result from the Process backend call
    * For now, this is GraphQL Service ONLY feature and it will basically refresh the Dataset & Pagination without having the user to create his own PostProcess every time

src/app/modules/angular-slickgrid/editors/autoCompleteEditor.ts

@@ -133,10 +133,13 @@ export class AutoCompleteEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/modules/angular-slickgrid/editors/dateEditor.ts

@@ -116,10 +116,13 @@ export class DateEditor implements Editor {
 
   save() {
     // autocommit will not focus the next editor
-    if (this.args.grid.getOptions().autoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.args.grid.getOptions().autoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/modules/angular-slickgrid/editors/floatEditor.ts

@@ -48,9 +48,6 @@ export class FloatEditor implements Editor {
         this._lastInputEvent = event;
         if (event.keyCode === KeyCode.LEFT || event.keyCode === KeyCode.RIGHT) {
           event.stopImmediatePropagation();
-        } else if (event.keyCode === KeyCode.ENTER) {
-          event.stopImmediatePropagation();
-          this.save();
         }
       });
 
@@ -146,10 +143,13 @@ export class FloatEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/modules/angular-slickgrid/editors/integerEditor.ts

@@ -103,10 +103,13 @@ export class IntegerEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }
 

src/app/modules/angular-slickgrid/editors/longTextEditor.ts

@@ -165,8 +165,13 @@ export class LongTextEditor implements Editor {
   }
 
   save() {
-    if (this.hasAutoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.hasAutoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     } else {
       this.args.commitChanges();
     }

src/app/modules/angular-slickgrid/editors/sliderEditor.ts

@@ -82,10 +82,13 @@ export class SliderEditor implements Editor {
   }
 
   save() {
-    if (this.args.grid.getOptions().autoCommitEdit) {
-      this.args.grid.getEditorLock().commitCurrentEdit();
-    } else {
-      this.args.commitChanges();
+    const validation = this.validate();
+    if (validation && validation.valid) {
+      if (this.args.grid.getOptions().autoCommitEdit) {
+        this.args.grid.getEditorLock().commitCurrentEdit();
+      } else {
+        this.args.commitChanges();
+      }
     }
   }