chore: fix failing unit tests

Author: ghiscoding

src/app/modules/angular-slickgrid/extensions/__tests__/slickRowDetailView.spec.ts

@@ -16,7 +16,6 @@ import { AngularUtilService } from '../../services';
 import { RowDetailView } from '../../models/rowDetailView.interface';
 import { RxJsResourceStub } from '../../../../../../test/rxjsResourceStub';
 import { SlickRowDetailView } from '../slickRowDetailView';
-jest.mock('@slickgrid-universal/row-detail-view-plugin');
 
 jest.mock('@slickgrid-universal/common', () => ({
   ...(jest.requireActual('@slickgrid-universal/common') as any),
@@ -33,6 +32,16 @@ jest.mock('@slickgrid-universal/common', () => ({
   })),
 }));
 
+jest.mock('@slickgrid-universal/row-detail-view-plugin', () => ({
+  ...(jest.requireActual('@slickgrid-universal/row-detail-view-plugin') as any),
+  onAsyncResponse: new SlickEvent(),
+  onAsyncEndUpdate: new SlickEvent(),
+  onAfterRowDetailToggle: new SlickEvent(),
+  onBeforeRowDetailToggle: new SlickEvent(),
+  onRowOutOfViewportRange: new SlickEvent(),
+  onRowBackToViewportRange: new SlickEvent(),
+}));
+
 const ROW_DETAIL_CONTAINER_PREFIX = 'container_';
 const PRELOAD_CONTAINER_PREFIX = 'container_loading';
 
@@ -74,6 +83,9 @@ const dataViewStub = {
   getItem: jest.fn(),
   getItems: jest.fn(),
   getItemCount: jest.fn(),
+  onRowCountChanged: new SlickEvent(),
+  onRowsChanged: new SlickEvent(),
+  onSetItemsCalled: new SlickEvent(),
 };
 
 const gridStub = {
@@ -85,6 +97,10 @@ const gridStub = {
   sanitizeHtmlString: (s: string) => s,
   onColumnsReordered: new SlickEvent(),
   onSelectedRowsChanged: new SlickEvent(),
+  onBeforeEditCell: new SlickEvent(),
+  onBeforeRemoveCachedRow: new SlickEvent(),
+  onClick: new SlickEvent(),
+  onScroll: new SlickEvent(),
   onSort: new SlickEvent(),
 } as unknown as SlickGrid;
 
@@ -109,7 +125,8 @@ describe('SlickRowDetailView', () => {
     rxjsResourceStub = new RxJsResourceStub();
 
     plugin = new SlickRowDetailView(angularUtilServiceStub, applicationRefStub, eventPubSubService, document.body as HTMLDivElement, rxjsResourceStub);
-    plugin.eventHandler = new SlickEventHandler();
+    // plugin.eventHandler = new SlickEventHandler();
+    jest.spyOn(plugin, 'eventHandler', 'get').mockReturnValue(eventHandler);
     jest.spyOn(plugin, 'getOptions').mockReturnValue(gridOptionsMock.rowDetailView as RowDetailView);
   });
 
@@ -420,7 +437,7 @@ describe('SlickRowDetailView', () => {
             model: mockColumn,
             addon: expect.anything(),
             grid: gridStub,
-            dataView: undefined,
+            dataView: dataViewStub,
             parent: undefined,
           });
           done();
@@ -452,7 +469,7 @@ describe('SlickRowDetailView', () => {
             model: mockColumn,
             addon: expect.anything(),
             grid: gridStub,
-            dataView: undefined,
+            dataView: dataViewStub,
             parent: undefined,
           });
         });
@@ -482,7 +499,7 @@ describe('SlickRowDetailView', () => {
               model: mockColumn,
               addon: expect.anything(),
               grid: gridStub,
-              dataView: undefined,
+              dataView: dataViewStub,
               parent: undefined,
             });
           });

src/app/modules/angular-slickgrid/extensions/slickRowDetailView.ts

@@ -4,7 +4,6 @@ import type {
   OnBeforeRowDetailToggleArgs,
   OnRowBackToViewportRangeArgs,
   RxJsFacade,
-  SlickEventHandler,
   SlickGrid,
 } from '@slickgrid-universal/common';
 import {
@@ -58,13 +57,6 @@ export class SlickRowDetailView extends UniversalSlickRowDetailView {
     return this.gridOptions.datasetIdPropertyName || 'id';
   }
 
-  get eventHandler(): SlickEventHandler {
-    return this._eventHandler;
-  }
-  set eventHandler(eventHandler: SlickEventHandler) {
-    this._eventHandler = eventHandler;
-  }
-
   /** Getter for the Grid Options pulled through the Grid Object */
   get gridOptions(): GridOption {
     return (this._grid?.getOptions() || {}) as GridOption;