Skip to content

Commit 0051d83

Browse files
committed
fix: use prop in instead of .hasOwn(prop)
1 parent 35a4c63 commit 0051d83

File tree

1 file changed

+17
-18
lines changed

1 file changed

+17
-18
lines changed

packages/excel-builder-vanilla/src/Excel/Workbook.ts

Lines changed: 17 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -240,27 +240,26 @@ export class Workbook {
240240
const definedNames = Util.createElement(doc, 'definedNames');
241241
let ctr = 0;
242242
for (const name in this.printTitles) {
243-
if (!this.printTitles.hasOwn(name)) {
244-
continue;
245-
}
246-
const entry = this.printTitles[name];
247-
const definedName = doc.createElement('definedName');
248-
definedName.setAttribute('name', '_xlnm.Print_Titles');
249-
definedName.setAttribute('localSheetId', ctr++);
250-
251-
let value = '';
252-
if (entry.top) {
253-
value += `${name}!$1:$${entry.top}`;
243+
if (name in this.printTitles) {
244+
const entry = this.printTitles[name];
245+
const definedName = doc.createElement('definedName');
246+
definedName.setAttribute('name', '_xlnm.Print_Titles');
247+
definedName.setAttribute('localSheetId', ctr++);
248+
249+
let value = '';
250+
if (entry.top) {
251+
value += `${name}!$1:$${entry.top}`;
252+
if (entry.left) {
253+
value += ',';
254+
}
255+
}
254256
if (entry.left) {
255-
value += ',';
257+
value += `${name}!$A:$${entry.left}`;
256258
}
257-
}
258-
if (entry.left) {
259-
value += `${name}!$A:$${entry.left}`;
260-
}
261259

262-
definedName.appendChild(doc.createTextNode(value));
263-
definedNames.appendChild(definedName);
260+
definedName.appendChild(doc.createTextNode(value));
261+
definedNames.appendChild(definedName);
262+
}
264263
}
265264
wb.appendChild(definedNames);
266265

0 commit comments

Comments
 (0)