Skip to content

Commit 1938720

Browse files
authored
fix: SASS deprecated lighten and darken methods (#301)
* fix: SASS deprecated `lighten` and `darken` methods - another deprecation from SASS which is again displaying a load of console warnings - more info on SASS website: https://sass-lang.com/documentation/breaking-changes/color-functions/
1 parent 5bb22e5 commit 1938720

File tree

4 files changed

+37
-23
lines changed

4 files changed

+37
-23
lines changed

packages/demo/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
},
2828
"devDependencies": {
2929
"@types/dompurify": "^3.0.5",
30-
"sass": "^1.77.8",
30+
"sass": "^1.79.3",
3131
"typescript": "5.5.4",
3232
"vite": "^5.4.2"
3333
}

packages/multiple-select-vanilla/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@
7878
"glob": "^10.4.5",
7979
"postcss": "^8.4.44",
8080
"postcss-cli": "^11.0.0",
81-
"sass": "^1.77.8",
81+
"sass": "^1.79.3",
8282
"typescript": "5.5.4"
8383
}
8484
}

packages/multiple-select-vanilla/src/styles/_variables.scss

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@use 'sass:color';
2+
13
/*
24
* Multiple-Select-Vanilla SASS variables.
35
* You can also CSS variables by simply replacing `$ms-` prefix with `--ms-`
@@ -11,7 +13,7 @@ $ms-primary-color: $primary-color !default;
1113
$ms-item-border: 1px solid transparent !default;
1214
$ms-item-hover-border: 1px solid #d5d5d5 !default;
1315
$ms-checkbox-color: $ms-primary-color !default;
14-
$ms-checkbox-hover-color: darken($ms-primary-color, 3%) !default;
16+
$ms-checkbox-hover-color: color.adjust($ms-primary-color, $lightness: -3%) !default;
1517
$ms-checkbox-icon-container-border: 1px solid #d0d0d0 !default;
1618
$ms-checkbox-icon-container-height: 1.05rem !default;
1719
$ms-checkbox-icon-container-width: 1.05rem !default;
@@ -34,7 +36,7 @@ $ms-icon-size: 1em !default;
3436
$ms-chevron-icon-size: 1.2em !default;
3537
$ms-choice-text-align: left !default;
3638
$ms-choice-line-height: 26px !default;
37-
$ms-choice-focus-border-color: lighten($ms-primary-color, 60%) !default;
39+
$ms-choice-focus-border-color: color.adjust($ms-primary-color, $lightness: 60%) !default;
3840
$ms-choice-focus-box-shadow: 0 0 0 1.5px rgba($ms-primary-color,.35) !default;
3941
$ms-drop-background: #fff !default;
4042
$ms-drop-color: #000 !default;
@@ -82,7 +84,7 @@ $ms-ok-button-border-width: 1px 0 0 0 !default;
8284
$ms-ok-button-font-weight: 600 !default;
8385
$ms-ok-button-padding: 0 !default;
8486
$ms-ok-button-text-color: $ms-primary-color !default;
85-
$ms-ok-button-text-hover-color: darken($ms-primary-color, 5%) !default;
87+
$ms-ok-button-text-hover-color: color.adjust($ms-primary-color, $lightness: -5%) !default;
8688
$ms-ok-button-height: 26px !default;
8789
$ms-ok-button-width: 100% !default;
8890
$ms-ok-button-text-align: center !default;
@@ -109,33 +111,33 @@ $ms-select-all-label-padding: 4px !default;
109111
$ms-select-all-line-height: 18px !default;
110112
$ms-select-all-padding: 4px !default;
111113
$ms-select-all-text-font-weight: normal !default;
112-
$ms-select-all-text-color: darken($ms-primary-color, 5%) !default;
114+
$ms-select-all-text-color: color.adjust($ms-primary-color, $lightness: -5%) !default;
113115
$ms-select-all-text-hover-color: transparent !default;
114116

115117
.ms-dark-mode {
116-
--ms-checkbox-color: #{lighten($ms-primary-color, 10%)};
117-
--ms-checkbox-hover-color: #{lighten($ms-primary-color, 13%)};
118+
--ms-checkbox-color: #{color.adjust($ms-primary-color, $lightness: 10%)};
119+
--ms-checkbox-hover-color: #{color.adjust($ms-primary-color, $lightness: 13%)};
118120
--ms-checkbox-icon-container-border: 1px solid #797979;
119121
--ms-choice-border: 1px solid #757575;
120122
--ms-choice-bgcolor: #262b2f;
121123
--ms-choice-color: #d4d4d4;
122124
--ms-choice-border-hover-color: #7f7f7f;
123-
--ms-choice-focus-border-color: #{lighten($ms-primary-color, 5%)};
125+
--ms-choice-focus-border-color: #{color.adjust($ms-primary-color, $lightness: 5%)};
124126
--ms-choice-focus-box-shadow: 0 0 0 2px #{rgba($ms-primary-color,.2)};
125127
--ms-drop-background: #2a2f34;
126128
--ms-drop-border: 1px solid #585858;
127129
--ms-drop-color: #cccccc;
128-
--ms-drop-hide-radio-hover-bgcolor: #{darken($ms-primary-color, 5%)};
130+
--ms-drop-hide-radio-hover-bgcolor: #{color.adjust($ms-primary-color, $lightness: -5%)};
129131
--ms-drop-option-divider-border-top: 1px solid #696969;
130132
--ms-drop-scrollbar-color: #828282 #424242;
131133
--ms-icon-color: #bcbcbc;
132134
--ms-icon-color-hover: #d0d0d0;
133-
--ms-option-highlight-bg-color: #{darken($ms-primary-color, 10%)};
135+
--ms-option-highlight-bg-color: #{color.adjust($ms-primary-color, $lightness: -10%)};
134136
--ms-ok-button-bg-color: #262b2f;
135137
--ms-ok-button-bg-hover-color: #24282c;
136138
--ms-ok-button-border-color: #4a4a4a;
137-
--ms-ok-button-text-color: #{lighten($ms-primary-color, 5%)};
138-
--ms-ok-button-text-hover-color: #{lighten($ms-primary-color, 5%)};
139+
--ms-ok-button-text-color: #{color.adjust($ms-primary-color, $lightness: 5%)};
140+
--ms-ok-button-text-hover-color: #{color.adjust($ms-primary-color, $lightness: 5%)};
139141
--ms-optgroup-color: #fff;
140142
--ms-search-input-bg-color: #2f353a;
141143
--ms-search-input-color: #d4d4d4;

pnpm-lock.yaml

Lines changed: 22 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)