Skip to content

Commit 52c9cc0

Browse files
authored
fix: don't use Boolean() for compatibility (#183)
- I'm not sure if it's related or not but this Angular-Slickgrid issue came up with this error so I wonder if this could help to use older code that is more compatibile
1 parent 444e751 commit 52c9cc0

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

lib/src/MultipleSelectInstance.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -312,7 +312,7 @@ export class MultipleSelectInstance {
312312
(row as OptionRowData).text = this.options.textTemplate(elm);
313313
row.value = elm.value;
314314
row.visible = true;
315-
row.selected = Boolean(elm.selected);
315+
row.selected = !!elm.selected;
316316
row.disabled = groupDisabled || elm.disabled;
317317
row.classes = elm.getAttribute('class') || '';
318318
row.title = elm.getAttribute('title') || '';
@@ -335,7 +335,7 @@ export class MultipleSelectInstance {
335335
row.type = 'optgroup';
336336
(row as OptGroupRowData).label = this.options.labelTemplate(elm);
337337
row.visible = true;
338-
row.selected = Boolean(elm.selected);
338+
row.selected = !!elm.selected;
339339
row.disabled = elm.disabled;
340340
(row as OptGroupRowData).children = [];
341341
if (Object.keys(elm.dataset).length) {
@@ -542,7 +542,7 @@ export class MultipleSelectInstance {
542542
type: 'checkbox',
543543
dataset: { name: this.selectGroupName, key: row._key },
544544
ariaChecked: String(row.selected || false),
545-
checked: Boolean(row.selected),
545+
checked: !!row.selected,
546546
disabled: row.disabled,
547547
tabIndex: -1,
548548
},
@@ -608,8 +608,8 @@ export class MultipleSelectInstance {
608608
value: encodeURI(row.value as string),
609609
dataset: { key: row._key, name: this.selectItemName },
610610
ariaChecked: String(row.selected || false),
611-
checked: Boolean(row.selected),
612-
disabled: Boolean(row.disabled),
611+
checked: !!row.selected,
612+
disabled: !!row.disabled,
613613
tabIndex: -1,
614614
},
615615
};

0 commit comments

Comments
 (0)