Skip to content

Commit 64e895b

Browse files
authored
fix: avoid barrel files, keep only 1 entry file (#304)
1 parent 2c10ebd commit 64e895b

28 files changed

+80
-51
lines changed

packages/multiple-select-vanilla/build-prod.mjs

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,16 @@ for (const format of buildFormats) {
3737
outfile: `dist/locales/multiple-select-all-locales.${extension}`,
3838
});
3939

40+
// - let's use TSUP to get valid hybrid (CJS/ESM) approach with are-the-types-wrong, however keep the rest of the build
4041
// finally, create a regular bundle as a standalone which will be accessible as MultipleSelect from the global window object
4142
// this file is basically a legacy alternative to import via a <script> tag
43+
/*
4244
runBuild({
4345
format,
4446
globalName: 'MultipleSelect',
4547
outfile: `dist/browser/multiple-select.${extension}`,
4648
});
49+
*/
4750
}
4851

4952
function runBuild(options) {

packages/multiple-select-vanilla/src/MultipleSelectInstance.ts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,12 @@
22
* @author zhixin wen <[email protected]>
33
*/
44
import Constants from './constants';
5-
import type { HtmlStruct, MultipleSelectLocales, OptGroupRowData, OptionDataObject, OptionRowData } from './interfaces';
6-
import type { CloseReason, MultipleSelectOption } from './interfaces/multipleSelectOption.interface';
7-
import { BindingEventService, VirtualScroll } from './services';
8-
import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils';
5+
import type { HtmlStruct, OptGroupRowData, OptionDataObject, OptionRowData } from './models/interfaces';
6+
import type { MultipleSelectLocales } from './models/locale.interface';
7+
import type { CloseReason, MultipleSelectOption } from './models/multipleSelectOption.interface';
8+
import { BindingEventService } from './services/binding-event.service';
9+
import { VirtualScroll } from './services/virtual-scroll';
10+
import { compareObjects, deepCopy, findByParam, removeDiacritics, removeUndefined, setDataKeys, stripScripts } from './utils/utils';
911
import {
1012
calculateAvailableSpace,
1113
classNameToList,

packages/multiple-select-vanilla/src/constants.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import type { LabelFilter, MultipleSelectOption, TextFilter } from './interfaces';
1+
import type { LabelFilter, TextFilter } from './models/interfaces';
2+
import type { MultipleSelectOption } from './models/multipleSelectOption.interface';
23
import English from './locales/multiple-select-en-US';
34

45
const BLOCK_ROWS = 50;
Lines changed: 36 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,36 @@
1-
export * from './services';
2-
export * from './constants';
3-
export * from './interfaces';
4-
export * from './utils';
5-
export * from './multiple-select';
6-
export * from './MultipleSelectInstance';
1+
export type * from './models/interfaces';
2+
export type * from './models/locale.interface';
3+
export type * from './models/multipleSelectOption.interface';
4+
export { BindingEventService, type ElementEventListener } from './services/binding-event.service';
5+
export { VirtualScroll } from './services/virtual-scroll';
6+
export {
7+
type HtmlElementPosition,
8+
calculateAvailableSpace,
9+
classNameToList,
10+
convertItemRowToHtml,
11+
createDomElement,
12+
createDomStructure,
13+
emptyElement,
14+
findParent,
15+
getElementOffset,
16+
getElementSize,
17+
insertAfter,
18+
omitProp,
19+
toggleElement,
20+
toggleElementClass,
21+
windowScrollPosition,
22+
} from './utils/domUtils';
23+
export {
24+
compareObjects,
25+
deepCopy,
26+
findByParam,
27+
isDefined,
28+
objectRemoveEmptyProps,
29+
removeDiacritics,
30+
removeUndefined,
31+
setDataKeys,
32+
stripScripts,
33+
toCamelCase,
34+
} from './utils/utils';
35+
export { multipleSelect } from './multiple-select';
36+
export { MultipleSelectInstance } from './MultipleSelectInstance';

packages/multiple-select-vanilla/src/interfaces/index.ts

Lines changed: 0 additions & 3 deletions
This file was deleted.

packages/multiple-select-vanilla/src/locales/multiple-select-cz-CS.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import type { MultipleSelectInstance } from '../MultipleSelectInstance';
7-
import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
7+
import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
88

99
const ms =
1010
typeof window !== 'undefined' && window.multipleSelect !== undefined

packages/multiple-select-vanilla/src/locales/multiple-select-da-DK.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import type { MultipleSelectInstance } from '../MultipleSelectInstance';
7-
import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
7+
import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
88

99
const ms =
1010
typeof window !== 'undefined' && window.multipleSelect !== undefined

packages/multiple-select-vanilla/src/locales/multiple-select-de-DE.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import type { MultipleSelectInstance } from '../MultipleSelectInstance';
7-
import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
7+
import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
88

99
const ms =
1010
typeof window !== 'undefined' && window.multipleSelect !== undefined

packages/multiple-select-vanilla/src/locales/multiple-select-en-US.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import type { MultipleSelectInstance } from '../MultipleSelectInstance';
7-
import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
7+
import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
88

99
const ms =
1010
typeof window !== 'undefined' && window.multipleSelect !== undefined

packages/multiple-select-vanilla/src/locales/multiple-select-es-ES.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*/
55

66
import type { MultipleSelectInstance } from '../MultipleSelectInstance';
7-
import type { MultipleSelectLocale, MultipleSelectLocales } from '../interfaces';
7+
import type { MultipleSelectLocale, MultipleSelectLocales } from '../models/locale.interface';
88

99
const ms =
1010
typeof window !== 'undefined' && window.multipleSelect !== undefined

0 commit comments

Comments
 (0)